Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C7047200D35 for ; Tue, 24 Oct 2017 02:43:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C5952160BF0; Tue, 24 Oct 2017 00:43:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 18D0F1609E0 for ; Tue, 24 Oct 2017 02:43:02 +0200 (CEST) Received: (qmail 83752 invoked by uid 500); 24 Oct 2017 00:43:02 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 83734 invoked by uid 99); 24 Oct 2017 00:43:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Oct 2017 00:43:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B2AAC18079F for ; Tue, 24 Oct 2017 00:43:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.363 X-Spam-Level: ** X-Spam-Status: No, score=2.363 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 1MaWaG1sRJgQ for ; Tue, 24 Oct 2017 00:42:59 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 3EAA85FB4E for ; Tue, 24 Oct 2017 00:42:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9O0gvaj005415; Tue, 24 Oct 2017 00:42:57 GMT Message-Id: <201710240042.v9O0gvaj005415@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Tue, 24 Oct 2017 00:42:57 +0000 From: "Alex Behm (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6060=3A_Check_the_return_value_of_JNI_exception_handling_functions=0A?= X-Gerrit-Change-Id: Ie3ed88bf8739c56a066f2402727c8204e96aa116 X-Gerrit-Change-Number: 8334 X-Gerrit-ChangeURL: X-Gerrit-Commit: 543927a09b4d89315161ef46a24017da8712dd0c In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 24 Oct 2017 00:42:57 +0000 Reply-To: alex.behm@cloudera.com, impala-cr@cloudera.com, twang@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="4AQyxvZLkrI="; charset=UTF-8 archived-at: Tue, 24 Oct 2017 00:43:04 -0000 --4AQyxvZLkrI= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Alex Behm has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/8334 ) Change subject: IMPALA-6060: Check the return value of = JNI exception handling functions =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E Patch Set 3: (1 comment) http://gerrit=2Ecloudera=2E= org:8080/#/c/8334/3/be/src/util/jni-util=2Ecc File be/src/util/jni-util=2Ec= c: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8334/3/be/src/util/jni-util=2Ec= c@190 PS3, Line 190: auto msg =3D static_cast(env->CallStaticObj= ectMethod(jni_util_class(), > Same here and in other cases below: The use o= f auto obscures the code=2E This It is somewhat obvious from the static_cas= t, of course=2E Still, auto generally adds cognitive burden to the reader u= nless it really helps readability -- To view, visit http://gerrit=2Eclo= udera=2Eorg:8080/8334 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:= 8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Mess= ageType: comment Gerrit-Change-Id: Ie3ed88bf8739c56a066f2402727c8204e96aa11= 6 Gerrit-Change-Number: 8334 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang <= twang@cloudera=2Ecom> Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date:= Tue, 24 Oct 2017 00:42:57 +0000 Gerrit-HasComments: Yes --4AQyxvZLkrI=--