Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 50A11200D35 for ; Tue, 24 Oct 2017 02:23:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4F37A160BF0; Tue, 24 Oct 2017 00:23:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 954451609E0 for ; Tue, 24 Oct 2017 02:23:53 +0200 (CEST) Received: (qmail 33832 invoked by uid 500); 24 Oct 2017 00:23:52 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 33820 invoked by uid 99); 24 Oct 2017 00:23:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Oct 2017 00:23:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C189CC1D02 for ; Tue, 24 Oct 2017 00:23:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.363 X-Spam-Level: ** X-Spam-Status: No, score=2.363 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id atd-kPuARrTR for ; Tue, 24 Oct 2017 00:23:49 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 910745FB4E for ; Tue, 24 Oct 2017 00:23:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9O0Nlg8004398; Tue, 24 Oct 2017 00:23:47 GMT Message-Id: <201710240023.v9O0Nlg8004398@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 11 Date: Tue, 24 Oct 2017 00:23:47 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Thomas Tauber-Marshall , Michael Ho X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5307=3A_Part_2=3A_copy_out_strings_in_uncompressed_Avro=0A?= X-Gerrit-Change-Id: If1fc78790d778c874f5aafa5958c3c045a88d233 X-Gerrit-Change-Number: 8146 X-Gerrit-ChangeURL: X-Gerrit-Commit: 651714b5f259ea361db845979381271397cc56bd In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 24 Oct 2017 00:23:47 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, kwho@cloudera.com, tmarshall@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="L+2QlT3CYjE="; charset=UTF-8 archived-at: Tue, 24 Oct 2017 00:23:54 -0000 --L+2QlT3CYjE= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8146 ) Change subject: IMPALA-5307: Part 2: copy out string= s in uncompressed Avro =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E Patch Set 11: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080= /#/c/8146/11/be/src/runtime/tuple=2Ecc File be/src/runtime/tuple=2Ecc: htt= p://gerrit=2Ecloudera=2Eorg:8080/#/c/8146/11/be/src/runtime/tuple=2Ecc@449 = PS11, Line 449: Value* result_val =3D builder=2ECreateCall(cross_compiled= _fn, > It's probably because of the inlining overhead=2E I wonder what the = perf is l I think being conservative is probably a good thing actually=2E T= he code is never executed in the common case where the Avro files are compr= essed so taking too much of a codegen time hit would be a bad thing=2E I c= ould do some further experiments to understand the impact - e=2Eg=2E compar= e the overhead of the unrolled and non-unrolled versions on 8 string column= s - would that be helpful? -- To view, visit http://gerrit=2Ecloudera= =2Eorg:8080/8146 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/= settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageTy= pe: comment Gerrit-Change-Id: If1fc78790d778c874f5aafa5958c3c045a88d233 Ger= rit-Change-Number: 8146 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Michael Ho = Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-R= eviewer: Tim Armstrong Gerrit-Comment-Date: Tue= , 24 Oct 2017 00:23:47 +0000 Gerrit-HasComments: Yes --L+2QlT3CYjE=--