Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CBD1A200D35 for ; Tue, 24 Oct 2017 00:15:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CA6FC160BF0; Mon, 23 Oct 2017 22:15:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1D4091609E0 for ; Tue, 24 Oct 2017 00:15:39 +0200 (CEST) Received: (qmail 74734 invoked by uid 500); 23 Oct 2017 22:15:39 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 74723 invoked by uid 99); 23 Oct 2017 22:15:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Oct 2017 22:15:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4EC1BC1E74 for ; Mon, 23 Oct 2017 22:15:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id zS8-wMcwtPsd for ; Mon, 23 Oct 2017 22:15:37 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 596C35F27D for ; Mon, 23 Oct 2017 22:15:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9NMFalM026345; Mon, 23 Oct 2017 22:15:36 GMT Message-Id: <201710232215.v9NMFalM026345@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 12 Date: Mon, 23 Oct 2017 22:15:36 +0000 From: "Michael Brown (Code Review)" To: Vuk Ercegovac , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Balazs Jeszenszky , Philip Zeyliger , Dimitris Tsirogiannis X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4704=3A_Turns_on_client_connections_when_local_catalog_initialized=2E=0A?= X-Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 X-Gerrit-Change-Number: 8202 X-Gerrit-ChangeURL: X-Gerrit-Commit: a26c39e8040a96e63490688ac479371517c104e3 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 23 Oct 2017 22:15:36 +0000 Reply-To: mikeb@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, dhecht@cloudera.com, philip@cloudera.com, reviews@impala.incubator.apache.org, dtsirogiannis@cloudera.com, vercegovac@cloudera.com, jeszyb@gmail.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="cRDhR7Z8kHw="; charset=UTF-8 archived-at: Mon, 23 Oct 2017 22:15:41 -0000 --cRDhR7Z8kHw= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Michael Brown has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8202 ) Change subject: IMPALA-4704: Turns on client connect= ions when local catalog initialized=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E Patch Set 12: Code-Review+1 (1 comment) for th= e test infra http://gerrit=2Ecloudera=2Eorg:8080/#/c/8202/11/bin/start-imp= ala-cluster=2Epy File bin/start-impala-cluster=2Epy: http://gerrit=2Ecloud= era=2Eorg:8080/#/c/8202/11/bin/start-impala-cluster=2Epy@317 PS11, Line 317= : > Done=2E Is there a python linter that folks use to catch cases like th= is? I like to use flake8 (pip install flake8)=2E I have this in setup=2Ecfg= : [flake8] ignore =3D E111,E114 max-line-length =3D 90 -- To vie= w, visit http://gerrit=2Ecloudera=2Eorg:8080/8202 To unsubscribe, visit htt= p://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerri= t-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52b881cba18= a7e4533e21a78751c2e35c3d4c8a6 Gerrit-Change-Number: 8202 Gerrit-PatchSet: 1= 2 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: = Balazs Jeszenszky Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Michael Brown Gerrit-Revi= ewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegova= c Gerrit-Comment-Date: Mon, 23 Oct 2017 22:15:3= 6 +0000 Gerrit-HasComments: Yes --cRDhR7Z8kHw=--