Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8E789200D28 for ; Mon, 23 Oct 2017 23:36:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8D1C51609E0; Mon, 23 Oct 2017 21:36:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D3B541609DF for ; Mon, 23 Oct 2017 23:36:13 +0200 (CEST) Received: (qmail 90339 invoked by uid 500); 23 Oct 2017 21:36:13 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 90328 invoked by uid 99); 23 Oct 2017 21:36:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Oct 2017 21:36:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 029AA1A1247 for ; Mon, 23 Oct 2017 21:36:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id atjLo510VDDJ for ; Mon, 23 Oct 2017 21:36:11 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 333845FE43 for ; Mon, 23 Oct 2017 21:36:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9NLa7rc022871; Mon, 23 Oct 2017 21:36:07 GMT Message-Id: <201710232136.v9NLa7rc022871@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 12 Date: Mon, 23 Oct 2017 21:36:07 +0000 From: "Lars Volker (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4177=2CIMPALA-6039=3A_batched_bit_reading_and_rle_decoding=0A?= X-Gerrit-Change-Id: I35de0cf80c86f501c4a39270afc8fb8111552ac6 X-Gerrit-Change-Number: 8267 X-Gerrit-ChangeURL: X-Gerrit-Commit: f1493b1f8401a507a105a738d8f51f1ed4ad3231 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 23 Oct 2017 21:36:07 +0000 Reply-To: lv@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="T1DhvQ/y8GM="; charset=UTF-8 archived-at: Mon, 23 Oct 2017 21:36:14 -0000 --T1DhvQ/y8GM= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Lars Volker has posted comments on this change=2E ( http://gerrit=2Eclouder= a=2Eorg:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit r= eading and rle decoding =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E Patch Set 12: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080= /#/c/8267/12/be/src/util/dict-test=2Ecc File be/src/util/dict-test=2Ecc: h= ttp://gerrit=2Ecloudera=2Eorg:8080/#/c/8267/12/be/src/util/dict-test=2Ecc@2= 55 PS12, Line 255: {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15= , 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, What is the benefit of this test? Won't it= stop when it tries to decode the first '10', just like the previous one? W= ouldn't it be better to put 32 successful decodes in front of the first fai= lure? -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8267 To uns= ubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Projec= t: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Chan= ge-Id: I35de0cf80c86f501c4a39270afc8fb8111552ac6 Gerrit-Change-Number: 8267= Gerrit-PatchSet: 12 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Tim Arm= strong Gerrit-Comment-Date: Mon, 23 Oct 2017 21= :36:07 +0000 Gerrit-HasComments: Yes --T1DhvQ/y8GM=--