Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 76C06200D28 for ; Mon, 23 Oct 2017 20:33:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 754151609E0; Mon, 23 Oct 2017 18:33:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B990E1609DF for ; Mon, 23 Oct 2017 20:33:28 +0200 (CEST) Received: (qmail 99309 invoked by uid 500); 23 Oct 2017 18:33:28 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 99287 invoked by uid 99); 23 Oct 2017 18:33:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Oct 2017 18:33:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E44ECC612C for ; Mon, 23 Oct 2017 18:33:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 93opfbLfRFc6 for ; Mon, 23 Oct 2017 18:33:26 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id F395F5FC1C for ; Mon, 23 Oct 2017 18:33:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9NIXPcu010956; Mon, 23 Oct 2017 18:33:25 GMT Message-Id: <201710231833.v9NIXPcu010956@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 8 Date: Mon, 23 Oct 2017 18:33:25 +0000 From: "Dan Hecht (Code Review)" To: Zoram Thanga , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5599=3A_Clean_up_references_to_TimestampValue_in_be/src=2E=0A?= X-Gerrit-Change-Id: I642a1d713597826bb7c15cd2ecb6638cb813a02c X-Gerrit-Change-Number: 8305 X-Gerrit-ChangeURL: X-Gerrit-Commit: 30f7edeff30ffe94f1e9ea7f21997051c099fd13 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 23 Oct 2017 18:33:25 +0000 Reply-To: dhecht@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, kwho@cloudera.com, zoram@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="3tTz/n88XPE="; charset=UTF-8 archived-at: Mon, 23 Oct 2017 18:33:29 -0000 --3tTz/n88XPE= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dan Hecht has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/8305 ) Change subject: IMPALA-5599: Clean up references to Tim= estampValue in be/src=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E Patch Set 8: Code-Review+2 (1 comment) http://gerrit=2Eclo= udera=2Eorg:8080/#/c/8305/8/be/src/util/time=2Eh File be/src/util/time=2Eh:= http://gerrit=2Ecloudera=2Eorg:8080/#/c/8305/8/be/src/util/time=2Eh@106 P= S8, Line 106: /// Convenience function to return the date-time string of th= e current time : /// derived from UnixMicros()=2E how about we= mention that this is in the local time zone=2E -- To view, visit http:= //gerrit=2Ecloudera=2Eorg:8080/8305 To unsubscribe, visit http://gerrit=2Ec= loudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: mast= er Gerrit-MessageType: comment Gerrit-Change-Id: I642a1d713597826bb7c15cd2e= cb6638cb813a02c Gerrit-Change-Number: 8305 Gerrit-PatchSet: 8 Gerrit-Owner:= Zoram Thanga Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Revie= wer: Zoram Thanga Gerrit-Comment-Date: Mon, 23 Oct 2= 017 18:33:25 +0000 Gerrit-HasComments: Yes --3tTz/n88XPE=--