Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 93AEC200D25 for ; Sun, 22 Oct 2017 21:02:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9239E160BD7; Sun, 22 Oct 2017 19:02:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AEA121609E1 for ; Sun, 22 Oct 2017 21:02:37 +0200 (CEST) Received: (qmail 85138 invoked by uid 500); 22 Oct 2017 19:02:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 85127 invoked by uid 99); 22 Oct 2017 19:02:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Oct 2017 19:02:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CDF0C1A0AF0 for ; Sun, 22 Oct 2017 19:02:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.562 X-Spam-Level: ** X-Spam-Status: No, score=2.562 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_MANYTO=0.2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id RX8sZAxJprC7 for ; Sun, 22 Oct 2017 19:02:32 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2EB465FC8D for ; Sun, 22 Oct 2017 19:02:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9MJ2L2x030935; Sun, 22 Oct 2017 19:02:21 GMT Message-Id: <201710221902.v9MJ2L2x030935@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 20 Date: Sun, 22 Oct 2017 19:02:20 +0000 From: "Tim Wood (Code Review)" To: Matthew Mulder , Michael Brown , David Knupp , Alex Behm , Mostafa Mokhtar , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5376=3A_Implement_all_TPCDS_test_cases_or_alternates_for_Impala=2E=0A?= X-Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 X-Gerrit-Change-Number: 8102 X-Gerrit-ChangeURL: X-Gerrit-Commit: f29f189a564b8b1946e30c2899b0a86449398df2 In-Reply-To: References: Reply-To: twood@cloudera.com, mmulder@cloudera.com, impala-cr@cloudera.com, dknupp@cloudera.com, marcelk@gmail.com, mmokhtar@cloudera.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org, mikeb@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="Osw6Po3mVSY="; charset=UTF-8 archived-at: Sun, 22 Oct 2017 19:02:38 -0000 --Osw6Po3mVSY= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Matthew Mulder, Michael Brown, David Knupp, Alex Behm, Mostafa Mokhta= r, Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change= =2E Please visit http://gerrit=2Ecloudera=2Eorg:8080/8102 to look at = the new patch set (#20)=2E Change subject: IMPALA-5376: Implement all TPCD= S test cases or alternates for Impala=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E IMPALA-5376: Implement all TPCDS test cases or= alternates for Impala=2E Main source for TPCDS query and result definitio= ns: https://github=2Ecom/gregrahn/tpcds-kit=2E TPC-DS v2=2E5=2E0 qualificat= ion queries from G=2E Rahn, Cloudera, Inc=2E Data set constructed in mini-c= luster using $IMPALA_HOME/buildall=2Esh -testdata=2E=2E=2E=2E This commit c= ontinues previous work on IMPALA-5376 in the ASF Impala repo and the Cloude= ra Gerrit service=2E This commit splits multi-query tests in the TPC-DS su= ite definition into one query and result set per test file, as the test fra= mework requires=2E Names for such files have -1, -2=2E=2E=2E inner suffixe= s=2E The portion of the TPC-DS test suite in this commit passes=2E It cont= ains no failures, as reflected by runs of $IMPALA_HOME/tests/run-tests=2Epy= query_test/test_tpcds_queries=2Epy =2E=2E=2E IMPALA-6007 addresses the TP= C-DS cases that require skipping (because we don't support them or they fla= p) or expected-failure (xfail, because we support them but they fail due to= bugs=2E) These require some added tooling for non-Pytest frameworks like = the stress test to avoid attempting them until they work=2E Tests that flap= are marked to skip, with a bug ID, since they don't reliably pass or xfail= =2E Expected result sets come from the TPC-DS kit=2E Some TPC-DS test cas= es in this commit have been modified in sematically-neutral ways so as to p= ass on Impala=2E The tests/query_test/test_tpcds_queries=2Epy driver file = is authoritative for the active/skip/xfail status for each case and a brief= reason=2E The following list describes the current status as: --- test-na= me deviance from TPC-DS spec changes made --- tpcds-q22a=2Etest RESULT MIS= MATCH in LSD of AVG() values FIXED, HAND_ROUNDED AVG() VALUES IN RESULT SET= --- tpcds-q26=2Etest RESULT MISMATCH in LSD of AVG() values ABSENT, IMPALA= -6087 --- tpcds-q28=2Etest RESULT MISMATCH in LSD of AVG() values ABSENT, I= MPALA-6087 --- tpcds-q30=2Etest UNRECOGNIZED CHARACTER ABSENT, IMPALA-5961= =2E --- tpcds-q31=2Etest RESULT MISMATCH in LSD of DECIMAL values ABSENT, I= MPALA-5956=2E --- tpcds-q35a=2Etest RESULT MISMATCH ABSENT, IMPALA-5950=2E = --- tpcds-q36a=2Etest RESULT MISMATCH ABSENT, IMPALA-4741 --- tpcds-q47=2Et= est RESULT MISMATCH in LSD of DECIMAL values ABSENT, IMPALA-6087 --- tpcds-= q48=2Etest RESULT MISMATCH in scalar value ABSENT, IMPALA-5950=2E --- tpcds= -q49=2Etest RESULT MISMATCH in LSD of DECIMAL values ABSENT, IMPALA-5945 --= - tpcds-q57=2Etest RESULT MISMATCH, excess scale in DECIMAL values ABSENT, = IMPALA-6087 --- tpcds-q58=2Etest RESULT MISMATCH in DECIMAL values ABSENT, = IMPALA-5946 --- tpcds-q59=2Etest RESULT MISMATCH, excess scale in DECIMAL v= alues ABSENT, IMPALA-6087 --- tpcds-q61=2Etest RESULT MISMATCH in DECIMAL v= alue FIXED=2E CAST RESULT QUOTIENT TO DECIMAL(15, 4), TAKE ACTUAL RESULT AS= EXPECTED --- tpcds-q63=2Etest RESULT MISMATCH, excess scale in DECIMAL val= ues ABSENT, IMPALA-6087 --- tpcds-q64=2Etest RESULT MISMATCH ADDED ORDER BY= COLUMNS=2E --- tpcds-q66=2Etest RESULT MISMATCH ABSENT, IMPALA-4741 --- tp= cds-q77a=2Etest RESULT MISMATCH FIXED=2E TAKE ACTUAL RESULT AS EXPECTED ---= tpcds-q78=2Etest RESULT MISMATCH FIXED=2E TAKE ACTUAL RESULT AS EXPECTED -= -- tpcds-q83=2Etest RESULT MISMATCH ABSENT, IMPALA-5945=2E --- tpcds-q85=2E= test MISSING TABLE "reason" ABSENT, IMPALA-5960 --- tpcds-q86a=2Etest RESUL= T MISMATCH FIXED=2E TAKE ACTUAL RESULT AS EXPECTED --- tpcds-q89=2Etest RES= ULT MISMATCH, DECIMAL values flap ABSENT, ADDED ROUND(2) TO 8th COLUMN, TAK= E ACTUAL RESULTS AS EXPECTED, IMPALA-5956=2E --- tpcds-q90=2Etest RESULT MI= SMATCH ABSENT, IMPALA-5945=2E --- tpcds-q93=2Etest MISSING TABLE "reason" A= BSENT, IMPALA-5960 --- tpcds-q98=2Etest RESULT MISMATCH FIXED, ADDED ROUND(= ) TO LAST COLUMN Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 --- = A testdata/workloads/tpcds/queries/tpcds-q10a=2Etest A testdata/workloads/t= pcds/queries/tpcds-q11=2Etest A testdata/workloads/tpcds/queries/tpcds-q12= =2Etest A testdata/workloads/tpcds/queries/tpcds-q13=2Etest A testdata/work= loads/tpcds/queries/tpcds-q15=2Etest A testdata/workloads/tpcds/queries/tpc= ds-q16=2Etest A testdata/workloads/tpcds/queries/tpcds-q17=2Etest A testdat= a/workloads/tpcds/queries/tpcds-q18a=2Etest A testdata/workloads/tpcds/quer= ies/tpcds-q20=2Etest A testdata/workloads/tpcds/queries/tpcds-q21=2Etest A = testdata/workloads/tpcds/queries/tpcds-q22a=2Etest D testdata/workloads/tpc= ds/queries/tpcds-q23-1=2Etest D testdata/workloads/tpcds/queries/tpcds-q23-= 2=2Etest A testdata/workloads/tpcds/queries/tpcds-q25=2Etest D testdata/wor= kloads/tpcds/queries/tpcds-q27=2Etest D testdata/workloads/tpcds/queries/tp= cds-q27a=2Etest D testdata/workloads/tpcds/queries/tpcds-q28=2Etest A testd= ata/workloads/tpcds/queries/tpcds-q29=2Etest A testdata/workloads/tpcds/que= ries/tpcds-q32=2Etest A testdata/workloads/tpcds/queries/tpcds-q33=2Etest A= testdata/workloads/tpcds/queries/tpcds-q37=2Etest A testdata/workloads/tpc= ds/queries/tpcds-q39-1=2Etest A testdata/workloads/tpcds/queries/tpcds-q39-= 2=2Etest A testdata/workloads/tpcds/queries/tpcds-q40=2Etest A testdata/wor= kloads/tpcds/queries/tpcds-q41=2Etest D testdata/workloads/tpcds/queries/tp= cds-q47=2Etest A testdata/workloads/tpcds/queries/tpcds-q50=2Etest A testda= ta/workloads/tpcds/queries/tpcds-q51=2Etest A testdata/workloads/tpcds/quer= ies/tpcds-q51a=2Etest A testdata/workloads/tpcds/queries/tpcds-q54=2Etest A= testdata/workloads/tpcds/queries/tpcds-q56=2Etest D testdata/workloads/tpc= ds/queries/tpcds-q59=2Etest A testdata/workloads/tpcds/queries/tpcds-q60=2E= test M testdata/workloads/tpcds/queries/tpcds-q61=2Etest A testdata/workloa= ds/tpcds/queries/tpcds-q62=2Etest D testdata/workloads/tpcds/queries/tpcds-= q63=2Etest A testdata/workloads/tpcds/queries/tpcds-q64=2Etest A testdata/w= orkloads/tpcds/queries/tpcds-q67a=2Etest A testdata/workloads/tpcds/queries= /tpcds-q69=2Etest A testdata/workloads/tpcds/queries/tpcds-q70a=2Etest A te= stdata/workloads/tpcds/queries/tpcds-q71=2Etest A testdata/workloads/tpcds/= queries/tpcds-q72=2Etest A testdata/workloads/tpcds/queries/tpcds-q74=2Etes= t A testdata/workloads/tpcds/queries/tpcds-q75=2Etest A testdata/workloads/= tpcds/queries/tpcds-q76=2Etest A testdata/workloads/tpcds/queries/tpcds-q77= a=2Etest A testdata/workloads/tpcds/queries/tpcds-q78=2Etest M testdata/wor= kloads/tpcds/queries/tpcds-q8=2Etest A testdata/workloads/tpcds/queries/tpc= ds-q80a=2Etest A testdata/workloads/tpcds/queries/tpcds-q81=2Etest A testda= ta/workloads/tpcds/queries/tpcds-q82=2Etest A testdata/workloads/tpcds/quer= ies/tpcds-q84=2Etest A testdata/workloads/tpcds/queries/tpcds-q86a=2Etest D= testdata/workloads/tpcds/queries/tpcds-q89=2Etest A testdata/workloads/tpc= ds/queries/tpcds-q91=2Etest A testdata/workloads/tpcds/queries/tpcds-q92=2E= test A testdata/workloads/tpcds/queries/tpcds-q94=2Etest A testdata/workloa= ds/tpcds/queries/tpcds-q95=2Etest A testdata/workloads/tpcds/queries/tpcds-= q97=2Etest M testdata/workloads/tpcds/queries/tpcds-q98=2Etest A testdata/w= orkloads/tpcds/queries/tpcds-q99=2Etest M tests/query_test/test_tpcds_queri= es=2Epy 62 files changed, 7,779 insertions(+), 2,403 deletions(-) git p= ull ssh://gerrit=2Ecloudera=2Eorg:29418/Impala-ASF refs/changes/02/8102/20 = -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8102 To unsubscribe,= visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala= -ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id= : I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 Gerrit-Change-Number: 8102 Gerr= it-PatchSet: 20 Gerrit-Owner: Tim Wood Gerrit-Review= er: Alex Behm Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer= : Matthew Mulder Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa M= okhtar Gerrit-Reviewer: Tim Wood --Osw6Po3mVSY=--