Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201710202304.v9KN4fAN013979@ip-10-146-233-104.ec2.internal>
Date: Fri, 20 Oct 2017 23:04:41 +0000
From: "Pranay Singh (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Joe McDonnell <joemcdonnell@cloudera.com>,
        Bikramjeet Vig <bikramjeet.vig@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5522=3AUse_tracked_memory_for_DictDecoder_and_DictEncoder=0A?=
In-Reply-To: <gerrit.1505172487000.I02a3b54f6c107d19b62ad9e1c49df94175964299@gerrit.cloudera.org>
References: <gerrit.1505172487000.I02a3b54f6c107d19b62ad9e1c49df94175964299@gerrit.cloudera.org>
Reply-To: impala-cr@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com,
        joemcdonnell@cloudera.com, reviews@impala.incubator.apache.org,
        bikramjeet.vig@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="2wR3WgT/kN0="; charset=UTF-8
archived-at: Fri, 20 Oct 2017 23:04:49 -0000

--2wR3WgT/kN0=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Pranay Singh has posted comments on this change=2E ( http://gerrit=2Ecloude=
ra=2Eorg:8080/8034 )

Change subject: IMPALA-5522:Use tracked memory for Di=
ctDecoder and DictEncoder
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E


Patch Set 10:

(5 comments)

http://gerrit=2Ecloudera=2Eorg:=
8080/#/c/8034/10/be/src/exec/hdfs-parquet-scanner=2Eh
File be/src/exec/hdfs=
-parquet-scanner=2Eh:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8034/10/be/s=
rc/exec/hdfs-parquet-scanner=2Eh@352
PS10, Line 352: return mem_tracker_;
>=
 if this is the same mem tracker in scan_node_ perhaps we can just do 
I tr=
ied that earlier but I was getting the below error for parquet table writer=
, so in order to have similar change in scanner and writer went this route
=

Error:
-----
hdfs-parquet-table-writer=2Eh:83:57: error: invalid use of in=
complete type =E2=80=98class impala::HdfsTableSink=E2=80=99


http://gerrit=
=2Ecloudera=2Eorg:8080/#/c/8034/10/be/src/exec/hdfs-parquet-scanner=2Ecc
Fi=
le be/src/exec/hdfs-parquet-scanner=2Ecc:

http://gerrit=2Ecloudera=2Eorg:8=
080/#/c/8034/10/be/src/exec/hdfs-parquet-scanner=2Ecc@337
PS10, Line 337: i=
f (mem_tracker_ !=3D nullptr) {
              :     mem_tracker_ =3D nullpt=
r;
              :   }
> nit: one line
Done


http://gerrit=2Ecloudera=2Eor=
g:8080/#/c/8034/10/be/src/exec/parquet-column-readers=2Eh
File be/src/exec/=
parquet-column-readers=2Eh:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8034/1=
0/be/src/exec/parquet-column-readers=2Eh@356
PS10, Line 356: if (dict_decod=
er_base_ !=3D nullptr) dict_decoder_base_->Close();
> instead of dict_decod=
er_base_ we can just use the virtual function GetDicti
GetDictionaryDecoder=
() returns dict_decoder_base_ it should be the same calling the function Ge=
tDictionaryDecoder() or accessing member variable  dict_decoder_base_ direc=
tly=2E


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8034/10/be/src/util/dict-e=
ncoding=2Eh
File be/src/util/dict-encoding=2Eh:

http://gerrit=2Ecloudera=
=2Eorg:8080/#/c/8034/10/be/src/util/dict-encoding=2Eh@206
PS10, Line 206: 
=
> nit: extra line
Done


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8034/10/be=
/src/util/dict-encoding=2Eh@324
PS10, Line 324: 
> nit: extra line
Done


=
-- 
To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8034
To unsubscribe,=
 visit http://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Impala=
-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0=
2a3b54f6c107d19b62ad9e1c49df94175964299
Gerrit-Change-Number: 8034
Gerrit-P=
atchSet: 10
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Bikramjeet Vig <bik=
ramjeet=2Evig@cloudera=2Ecom>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@=
cloudera=2Ecom>
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstron=
g <tarmstrong@cloudera=2Ecom>
Gerrit-Comment-Date: Fri, 20 Oct 2017 23:04:4=
1 +0000
Gerrit-HasComments: Yes

--2wR3WgT/kN0=--