Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4FCAA200D31 for ; Sat, 21 Oct 2017 00:57:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4E571160BEE; Fri, 20 Oct 2017 22:57:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 91CA5160BCB for ; Sat, 21 Oct 2017 00:57:02 +0200 (CEST) Received: (qmail 59701 invoked by uid 500); 20 Oct 2017 22:57:01 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 59690 invoked by uid 99); 20 Oct 2017 22:57:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Oct 2017 22:57:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B9CFE1807D7 for ; Fri, 20 Oct 2017 22:57:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 04PGvOpJpnpS for ; Fri, 20 Oct 2017 22:56:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 586485FBE6 for ; Fri, 20 Oct 2017 22:56:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9KMuv7a013698; Fri, 20 Oct 2017 22:56:57 GMT Message-Id: <201710202256.v9KMuv7a013698@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 10 Date: Fri, 20 Oct 2017 22:56:57 +0000 From: "Vuk Ercegovac (Code Review)" To: Philip Zeyliger , Balazs Jeszenszky , Dimitris Tsirogiannis , Dan Hecht , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4704=3A_Turns_on_client_connections_when_local_catalog_initialized=2E=0A?= X-Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 X-Gerrit-Change-Number: 8202 X-Gerrit-ChangeURL: X-Gerrit-Commit: 88104d389edee32a4a251cda363313e5a9c5a0dd In-Reply-To: References: Reply-To: vercegovac@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, dhecht@cloudera.com, philip@cloudera.com, reviews@impala.incubator.apache.org, dtsirogiannis@cloudera.com, jeszyb@gmail.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="Qd7HEGakrNM="; charset=UTF-8 archived-at: Fri, 20 Oct 2017 22:57:03 -0000 --Qd7HEGakrNM= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Philip Zeyliger, Balazs Jeszenszky, Dimitris Tsirogiannis, Dan Hecht,= I'd like you to reexamine a change=2E Please visit http://gerrit=2E= cloudera=2Eorg:8080/8202 to look at the new patch set (#10)=2E Change sub= ject: IMPALA-4704: Turns on client connections when local catalog initializ= ed=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E IMPALA-= 4704: Turns on client connections when local catalog initialized=2E Curren= tly, impalad starts beeswax and hs2 servers even if the catalog has not yet= been initialized=2E As a result, client connections see an error message s= tating that the impalad is not yet ready=2E This patch changes the impalad= startup sequence to wait until the catalog is received before opening bees= wax and hs2 ports and starting their servers=2E Testing: - python e2e test= s that start a cluster without a catalog and check that client connection= s are rejected as expected=2E Change-Id: I52b881cba18a7e4533e21a78751c2e35= c3d4c8a6 --- M be/src/service/frontend=2Ecc M be/src/service/frontend=2Eh M= be/src/service/impala-server=2Ecc M be/src/testutil/in-process-servers=2Ec= c M bin/start-impala-cluster=2Epy M fe/src/main/java/org/apache/impala/serv= ice/Frontend=2Ejava M fe/src/main/java/org/apache/impala/service/JniFronten= d=2Ejava M fe/src/test/java/org/apache/impala/service/FrontendTest=2Ejava M= tests/common/custom_cluster_test_suite=2Epy M tests/common/impala_cluster= =2Epy M tests/common/impala_service=2Epy A tests/custom_cluster/test_catalo= g_wait=2Epy M tests/custom_cluster/test_coordinators=2Epy 13 files changed,= 169 insertions(+), 71 deletions(-) git pull ssh://gerrit=2Ecloudera=2E= org:29418/Impala-ASF refs/changes/02/8202/10 -- To view, visit http://gerr= it=2Ecloudera=2Eorg:8080/8202 To unsubscribe, visit http://gerrit=2Eclouder= a=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Ger= rit-MessageType: newpatchset Gerrit-Change-Id: I52b881cba18a7e4533e21a78751= c2e35c3d4c8a6 Gerrit-Change-Number: 8202 Gerrit-PatchSet: 10 Gerrit-Owner: = Vuk Ercegovac Gerrit-Reviewer: Balazs Jeszenszk= y Gerrit-Reviewer: Dan Hecht G= errit-Reviewer: Dimitris Tsirogiannis Gerrit= -Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Erc= egovac --Qd7HEGakrNM=--