Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201710202238.v9KMcs2r012966@ip-10-146-233-104.ec2.internal>
Date: Fri, 20 Oct 2017 22:38:54 +0000
From: "Impala Public Jenkins (Code Review)" <gerrit@cloudera.org>
To: Csaba Ringhofer <csringhofer@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5668=3A_Fix_cast=28X_as_timestamp=29_for_negative_subsecond_Decimals=0A?=
In-Reply-To: <gerrit.1505316519000.I8216f4c0f100c1bd68891cd6048236bfe4c205f0@gerrit.cloudera.org>
References: <gerrit.1505316519000.I8216f4c0f100c1bd68891cd6048236bfe4c205f0@gerrit.cloudera.org>
Reply-To: impala-cr@cloudera.com, csringhofer@cloudera.com,
        reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="OxfPcOa1W88="; charset=UTF-8
archived-at: Fri, 20 Oct 2017 22:39:00 -0000

--OxfPcOa1W88=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Impala Public Jenkins has submitted this change and it was merged=2E ( http=
://gerrit=2Ecloudera=2Eorg:8080/8051 )

Change subject: IMPALA-5668: Fix ca=
st(X as timestamp) for negative subsecond Decimals
=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E

IMPALA-5668: Fix cast(X as timestamp)=
 for negative subsecond Decimals

The timestamp conversion from negative fr=
actional Decimal types
(interpreted as unix timestamp) was wrong - the whol=
e part
was rounded toward zero, and fractional part was being added
instead=
 of being subtracted=2E This is fixed by subtracting the
fractional part in=
 case of negative decimals=2E

Example for the wrong behaviour:
+----------=
---------------------------------------+
| cast(cast(-0=2E1 as decimal(18,1=
0)) as timestamp) |
+-------------------------------------------------+
| 1=
970-01-01 00:00:00=2E100000000                   |
+-----------------------=
--------------------------+
while casting to double works correctly:
+-----=
------------------------------------+
| cast(cast(-0=2E1 as double) as time=
stamp) |
+-----------------------------------------+
| 1969-12-31 23:59:59=
=2E900000000           |
+-----------------------------------------+

Chang=
e-Id: I8216f4c0f100c1bd68891cd6048236bfe4c205f0
Reviewed-on: http://gerrit=
=2Ecloudera=2Eorg:8080/8051
Reviewed-by: Tim Armstrong <tarmstrong@cloudera=
=2Ecom>
Tested-by: Impala Public Jenkins
---
M be/src/exprs/decimal-operato=
rs-ir=2Ecc
M be/src/exprs/decimal-operators=2Eh
M be/src/exprs/expr-test=2E=
cc
M be/src/runtime/decimal-value=2Eh
M be/src/runtime/timestamp-value=2Eh
=
5 files changed, 45 insertions(+), 37 deletions(-)

Approvals:
  Tim Armstr=
ong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To v=
iew, visit http://gerrit=2Ecloudera=2Eorg:8080/8051
To unsubscribe, visit h=
ttp://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Ger=
rit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8216f4c0f1=
00c1bd68891cd6048236bfe4c205f0
Gerrit-Change-Number: 8051
Gerrit-PatchSet: =
7
Gerrit-Owner: Csaba Ringhofer <csringhofer@cloudera=2Ecom>
Gerrit-Reviewe=
r: Csaba Ringhofer <csringhofer@cloudera=2Ecom>
Gerrit-Reviewer: Impala Pub=
lic Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera=2Ecom>
Gerrit-Reviewe=
r: Tim Armstrong <tarmstrong@cloudera=2Ecom>

--OxfPcOa1W88=--