Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D7B0C200D26 for ; Fri, 20 Oct 2017 21:56:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D6436160BCB; Fri, 20 Oct 2017 19:56:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2887C1609ED for ; Fri, 20 Oct 2017 21:56:48 +0200 (CEST) Received: (qmail 47159 invoked by uid 500); 20 Oct 2017 19:56:47 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 47127 invoked by uid 99); 20 Oct 2017 19:56:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Oct 2017 19:56:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2B1AC180715 for ; Fri, 20 Oct 2017 19:56:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Rv6Z1XjsUmFR for ; Fri, 20 Oct 2017 19:56:45 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id F17FD5FBE6 for ; Fri, 20 Oct 2017 19:56:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9KJui0s008571; Fri, 20 Oct 2017 19:56:44 GMT Message-Id: <201710201956.v9KJui0s008571@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 2 Date: Fri, 20 Oct 2017 19:56:44 +0000 From: "Taras Bobrovytsky (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5018=3A_Error_on_decimal_modulo_or_divide_by_zero=0A?= X-Gerrit-Change-Id: If7a7131e657fcdd293ade78d62f851dac0f1e3eb X-Gerrit-Change-Number: 8344 X-Gerrit-ChangeURL: X-Gerrit-Commit: fc51f7f0804d29952e3d0f15dd4ded4cacd298b1 In-Reply-To: References: Reply-To: tbobrovytsky@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="J1fny0i6DVw="; charset=UTF-8 archived-at: Fri, 20 Oct 2017 19:56:49 -0000 --J1fny0i6DVw= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Taras Bobrovytsky has uploaded a new patch set (#2)=2E ( http://gerrit=2Ecl= oudera=2Eorg:8080/8344 ) Change subject: IMPALA-5018: Error on decimal mod= ulo or divide by zero =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E IMPALA-5018: Error on decimal modulo or divide by zero Before t= his patch, decimal operations would never produce an error=2E Division by a= nd modulo zero would result in a NULL=2E In this patch, we change this beh= avior so that we raise an error instead of returning a NULL=2E We also modi= fy the format of the decimal expr tests format to also include an error fie= ld=2E Testing: - Added several expr and end to end tests=2E Change-Id: If= 7a7131e657fcdd293ade78d62f851dac0f1e3eb --- M be/src/exprs/decimal-operator= s-ir=2Ecc M be/src/exprs/expr-test=2Ecc M testdata/workloads/functional-que= ry/queries/QueryTest/decimal-exprs=2Etest 3 files changed, 654 insertions(+= ), 563 deletions(-) git pull ssh://gerrit=2Ecloudera=2Eorg:29418/Impala= -ASF refs/changes/44/8344/2 -- To view, visit http://gerrit=2Ecloudera=2Eo= rg:8080/8344 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/sett= ings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: = newpatchset Gerrit-Change-Id: If7a7131e657fcdd293ade78d62f851dac0f1e3eb Ger= rit-Change-Number: 8344 Gerrit-PatchSet: 2 Gerrit-Owner: Taras Bobrovytsky = Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Taras Bobrovytsky Gerri= t-Reviewer: Tim Armstrong Gerrit-Reviewer: Vuk = Ercegovac Gerrit-Reviewer: Zach Amsden --J1fny0i6DVw=--