Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201710200359.v9K3xnwU026067@ip-10-146-233-104.ec2.internal>
Date: Fri, 20 Oct 2017 03:59:49 +0000
From: "Impala Public Jenkins (Code Review)" <gerrit@cloudera.org>
To: Tianyi Wang <twang@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5789=3A_Add_always_false_flag_in_bloom_filter=0A?=
In-Reply-To: <gerrit.1506648261000.If680240a3cd4583fc97c3192177d86d9567c4f8d@gerrit.cloudera.org>
References: <gerrit.1506648261000.If680240a3cd4583fc97c3192177d86d9567c4f8d@gerrit.cloudera.org>
Reply-To: impala-cr@cloudera.com, twang@cloudera.com,
        reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="fwv+qLq1lGg="; charset=UTF-8
archived-at: Fri, 20 Oct 2017 03:59:55 -0000

--fwv+qLq1lGg=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Impala Public Jenkins has submitted this change and it was merged=2E ( http=
://gerrit=2Ecloudera=2Eorg:8080/8170 )

Change subject: IMPALA-5789: Add al=
ways_false flag in bloom filter
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E

IMPALA-5789: Add always_false flag in bloom filter

Thi=
s patch adds an always_false flag in bloom filters=2E The flag is set
if no=
thing has been inserted into the bloom filter=2E HdfsScanner uses
this flag=
 to early terminate the scan at file and split granularities=2E

Testing: I=
t passes existing tests=2E Two test cases are added checking
that an always=
-false runtime filter can filter out files and splits=2E
In single node per=
f tests, time spent on primitive_empty_build_join_1
is reduced by 75%=2E

C=
hange-Id: If680240a3cd4583fc97c3192177d86d9567c4f8d
Reviewed-on: http://ger=
rit=2Ecloudera=2Eorg:8080/8170
Reviewed-by: Tim Armstrong <tarmstrong@cloud=
era=2Ecom>
Tested-by: Impala Public Jenkins
---
M be/src/common/global-flag=
s=2Ecc
M be/src/exec/base-sequence-scanner=2Ecc
M be/src/exec/base-sequence=
-scanner=2Eh
M be/src/exec/filter-context=2Ecc
M be/src/exec/filter-context=
=2Eh
M be/src/exec/hdfs-parquet-scanner=2Ecc
M be/src/exec/hdfs-scan-node-b=
ase=2Ecc
M be/src/exec/hdfs-scan-node=2Ecc
M be/src/exec/hdfs-scanner=2Ecc
=
M be/src/runtime/coordinator-backend-state=2Ecc
M be/src/runtime/coordinato=
r-backend-state=2Eh
M be/src/runtime/coordinator-filter-state=2Eh
M be/src/=
runtime/coordinator=2Ecc
M be/src/runtime/runtime-filter-ir=2Ecc
M be/src/r=
untime/runtime-filter=2Eh
M be/src/runtime/runtime-filter=2Einline=2Eh
M be=
/src/util/bloom-filter-ir=2Ecc
M be/src/util/bloom-filter=2Ecc
M be/src/uti=
l/bloom-filter=2Eh
M common/thrift/ImpalaInternalService=2Ethrift
A tests/c=
ustom_cluster/test_always_false_filter=2Epy
M tests/query_test/test_runtime=
_filters=2Epy
22 files changed, 200 insertions(+), 197 deletions(-)

Approv=
als:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: V=
erified

-- 
To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8170
To uns=
ubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Projec=
t: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Chang=
e-Id: If680240a3cd4583fc97c3192177d86d9567c4f8d
Gerrit-Change-Number: 8170
=
Gerrit-PatchSet: 9
Gerrit-Owner: Tianyi Wang <twang@cloudera=2Ecom>
Gerrit-=
Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sailesh@clo=
udera=2Ecom>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera=2E=
com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera=2Ecom>
Gerrit-Reviewer: T=
im Armstrong <tarmstrong@cloudera=2Ecom>

--fwv+qLq1lGg=--