Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 167BB200D1E for ; Thu, 19 Oct 2017 00:00:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 15149160BEA; Wed, 18 Oct 2017 22:00:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 59C6E1609DE for ; Thu, 19 Oct 2017 00:00:11 +0200 (CEST) Received: (qmail 33266 invoked by uid 500); 18 Oct 2017 22:00:10 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 33255 invoked by uid 99); 18 Oct 2017 22:00:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2017 22:00:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 65374CE487 for ; Wed, 18 Oct 2017 22:00:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id NREU9DCDajoD for ; Wed, 18 Oct 2017 22:00:08 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D37D05F1D5 for ; Wed, 18 Oct 2017 22:00:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9IM05vM014042; Wed, 18 Oct 2017 22:00:05 GMT Message-Id: <201710182200.v9IM05vM014042@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Wed, 18 Oct 2017 22:00:05 +0000 From: "Tim Armstrong (Code Review)" To: Csaba Ringhofer , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Lars Volker X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5668=3A_Fix_cast=28X_as_timestamp=29_for_negative_subsecond_Decimals=0A?= X-Gerrit-Change-Id: I8216f4c0f100c1bd68891cd6048236bfe4c205f0 X-Gerrit-Change-Number: 8051 X-Gerrit-ChangeURL: X-Gerrit-Commit: 22cece4dfe342aeb4bd10e9e6accc16f6f971652 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 18 Oct 2017 22:00:05 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com, marcelk@gmail.com, csringhofer@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="6PpxWLDKqKw="; charset=UTF-8 archived-at: Wed, 18 Oct 2017 22:00:12 -0000 --6PpxWLDKqKw= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp= ) for negative subsecond Decimals =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E Patch Set 4: (2 comments) Thanks for fixing this= =2E Just had a couple of minor requests then I'll +2=2E http://gerrit=2Ecl= oudera=2Eorg:8080/#/c/8051/4/be/src/exprs/decimal-operators-ir=2Ecc File be= /src/exprs/decimal-operators-ir=2Ecc: http://gerrit=2Ecloudera=2Eorg:8080/= #/c/8051/4/be/src/exprs/decimal-operators-ir=2Ecc@604 PS4, Line 604: DCHE= CK(nanoseconds >=3D numeric_limits::min() We generally prefer DCHE= CK_GE() and DCHECK_LE() so that the out-of-range value is printed if this g= ets hit=2E http://gerrit=2Ecloudera=2Eorg:8080/#/c/8051/4/be/src/exprs/de= cimal-operators-ir=2Ecc@622 PS4, Line 622: FromUnixTimeNanos Can you add a = note to this function's comment that it's expected to work for negative nan= oseconds (I don't think it's obvious when looking at the function definitio= n)=2E -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8051 To uns= ubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Projec= t: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Chan= ge-Id: I8216f4c0f100c1bd68891cd6048236bfe4c205f0 Gerrit-Change-Number: 8051= Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer Gerrit-Reviewer: Csaba Ringhofer Gerrit-Re= viewer: Lars Volker Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Wed, 18 Oct 2017 22:00:05 +000= 0 Gerrit-HasComments: Yes --6PpxWLDKqKw=--