Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201710181747.v9IHlPwd032275@ip-10-146-233-104.ec2.internal>
Date: Wed, 18 Oct 2017 17:47:25 +0000
From: "Philip Zeyliger (Code Review)" <gerrit@cloudera.org>
To: Laszlo Gaal <laszlo.gaal@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>, Dan Hecht <dhecht@cloudera.com>,
        Sailesh Mukil <sailesh@cloudera.com>, Lars Volker <lv@cloudera.com>,
        Michael Brown <mikeb@cloudera.com>, David Knupp <dknupp@cloudera.com>,
        Joe McDonnell <joemcdonnell@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6067=3A_Enable_s3_access_via_IAM_roles_for_EC2_VMs=0A?=
In-Reply-To: <gerrit.1508257187000.I14cd9d4453a91baad3c379aa7e4944993fca95ae@gerrit.cloudera.org>
References: <gerrit.1508257187000.I14cd9d4453a91baad3c379aa7e4944993fca95ae@gerrit.cloudera.org>
Reply-To: philip@cloudera.com, impala-cr@cloudera.com, sailesh@cloudera.com,
        dknupp@cloudera.com, lv@cloudera.com, marcelk@gmail.com,
        dhecht@cloudera.com, joemcdonnell@cloudera.com,
        laszlo.gaal@cloudera.com, alex.behm@cloudera.com,
        reviews@impala.incubator.apache.org, mikeb@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="LJCd2fqjG/c="; charset=UTF-8
archived-at: Wed, 18 Oct 2017 17:47:32 -0000

--LJCd2fqjG/c=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Philip Zeyliger has posted comments on this change=2E ( http://gerrit=2Eclo=
udera=2Eorg:8080/8294 )

Change subject: IMPALA-6067: Enable s3 access via =
IAM roles for EC2 VMs
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E


Patch Set 1:

(1 comment)

http://gerrit=2Ecloudera=2Eorg:8080/=
#/c/8294/1/bin/impala-config=2Esh
File bin/impala-config=2Esh:

http://gerr=
it=2Ecloudera=2Eorg:8080/#/c/8294/1/bin/impala-config=2Esh@256
PS1, Line 25=
6: if [[ -z ${AWS_ACCESS_KEY_ID-} ]]; then
> We may want to include a check=
 here that "set -x" has not been enabled?
(Bash hackery)

If you want, you =
can use a subshell:

$(set -x; (set +x; [ $USER =3D=3D philip ])) && echo y=
es || echo no
+ set +x
yes
10:46:02 mystery  ~
$(set -x; (set +x; [ $USER =
=3D=3D phili ])) && echo yes || echo no
+ set +x
no


Return values survive=
, and you can just do

if (set +x; [[ -z ${AWS_SECRET_ACCESS_KEY_ID-} ]]); =
then
  =2E=2E=2E
fi

I tested something similar above=2E


-- 
To view, vi=
sit http://gerrit=2Ecloudera=2Eorg:8080/8294
To unsubscribe, visit http://g=
errit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Bra=
nch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14cd9d4453a91baa=
d3c379aa7e4944993fca95ae
Gerrit-Change-Number: 8294
Gerrit-PatchSet: 1
Gerr=
it-Owner: Laszlo Gaal <laszlo=2Egaal@cloudera=2Ecom>
Gerrit-Reviewer: Alex =
Behm <alex=2Ebehm@cloudera=2Ecom>
Gerrit-Reviewer: Dan Hecht <dhecht@cloude=
ra=2Ecom>
Gerrit-Reviewer: David Knupp <dknupp@cloudera=2Ecom>
Gerrit-Revie=
wer: Joe McDonnell <joemcdonnell@cloudera=2Ecom>
Gerrit-Reviewer: Lars Volk=
er <lv@cloudera=2Ecom>
Gerrit-Reviewer: Laszlo Gaal <laszlo=2Egaal@cloudera=
=2Ecom>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera=2Ecom>
Gerrit-Review=
er: Philip Zeyliger <philip@cloudera=2Ecom>
Gerrit-Reviewer: Sailesh Mukil =
<sailesh@cloudera=2Ecom>
Gerrit-Comment-Date: Wed, 18 Oct 2017 17:47:25 +00=
00
Gerrit-HasComments: Yes

--LJCd2fqjG/c=--