Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201710172309.v9HN980m019268@ip-10-146-233-104.ec2.internal>
Date: Tue, 17 Oct 2017 23:09:08 +0000
From: "Michael Brown (Code Review)" <gerrit@cloudera.org>
To: Laszlo Gaal <laszlo.gaal@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>, Dan Hecht <dhecht@cloudera.com>,
        Sailesh Mukil <sailesh@cloudera.com>, Lars Volker <lv@cloudera.com>,
        Philip Zeyliger <philip@cloudera.com>,
        David Knupp <dknupp@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6067=3A_Enable_s3_access_via_IAM_roles_for_EC2_VMs=0A?=
In-Reply-To: <gerrit.1508257187000.I14cd9d4453a91baad3c379aa7e4944993fca95ae@gerrit.cloudera.org>
References: <gerrit.1508257187000.I14cd9d4453a91baad3c379aa7e4944993fca95ae@gerrit.cloudera.org>
Reply-To: mikeb@cloudera.com, impala-cr@cloudera.com, sailesh@cloudera.com,
        dknupp@cloudera.com, lv@cloudera.com, marcelk@gmail.com,
        dhecht@cloudera.com, laszlo.gaal@cloudera.com, philip@cloudera.com,
        alex.behm@cloudera.com, reviews@impala.incubator.apache.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="LRmrnUc3auE="; charset=UTF-8
archived-at: Tue, 17 Oct 2017 23:09:15 -0000

--LRmrnUc3auE=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Michael Brown has posted comments on this change=2E ( http://gerrit=2Ecloud=
era=2Eorg:8080/8294 )

Change subject: IMPALA-6067: Enable s3 access via IA=
M roles for EC2 VMs
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E


Patch Set 1:

(5 comments)

http://gerrit=2Ecloudera=2Eorg:8080/#/=
c/8294/1//COMMIT_MSG
Commit Message:

http://gerrit=2Ecloudera=2Eorg:8080/#=
/c/8294/1//COMMIT_MSG@9
PS1, Line 9: JENKINS-1102 added the IAM role Impala=
Dev to the Impala Jenkins workers
           : to facilitate s3 access with=
out having to carry around AWS credentials
           : in environment vari=
ables, from where they were prone to escape to log
           : files poste=
d in public places=2E
This looks like something specific to a downstream en=
vironment and should be removed from the commit message=2E


http://gerrit=
=2Ecloudera=2Eorg:8080/#/c/8294/1/bin/impala-config=2Esh
File bin/impala-co=
nfig=2Esh:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8294/1/bin/impala-confi=
g=2Esh@268
PS1, Line 268: test
tests


http://gerrit=2Ecloudera=2Eorg:8080/=
#/c/8294/1/bin/impala-config=2Esh@276
PS1, Line 276: curl -sf --connect-tim=
eout 1 --max-time 5
Are these curl options common across a wide variety of =
OSs? If they are newer and only work under, say, Ubuntu 16, they would be a=
 problem for contributors using older distributions=2E


http://gerrit=2Ecl=
oudera=2Eorg:8080/#/c/8294/1/bin/impala-config=2Esh@276
PS1, Line 276: http=
://169=2E254=2E169=2E254/latest/meta-data/iam/security-credentials/
Is ther=
e a AWS reference page you can add as a comment so I can read up more on th=
is?


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8294/1/testdata/cluster/node_=
templates/common/etc/hadoop/conf/core-site=2Exml=2Etmpl
File testdata/clust=
er/node_templates/common/etc/hadoop/conf/core-site=2Exml=2Etmpl:

http://ge=
rrit=2Ecloudera=2Eorg:8080/#/c/8294/1/testdata/cluster/node_templates/commo=
n/etc/hadoop/conf/core-site=2Exml=2Etmpl@61
PS1, Line 61: <!-- BEGIN s3 sec=
urity settings -->
Maybe have a comment explaining testdata/cluster/admin n=
eeds this (and the END) as a marker and not to remove?


-- 
To view, visi=
t http://gerrit=2Ecloudera=2Eorg:8080/8294
To unsubscribe, visit http://ger=
rit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branc=
h: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14cd9d4453a91baad3=
c379aa7e4944993fca95ae
Gerrit-Change-Number: 8294
Gerrit-PatchSet: 1
Gerrit=
-Owner: Laszlo Gaal <laszlo=2Egaal@cloudera=2Ecom>
Gerrit-Reviewer: Alex Be=
hm <alex=2Ebehm@cloudera=2Ecom>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera=
=2Ecom>
Gerrit-Reviewer: David Knupp <dknupp@cloudera=2Ecom>
Gerrit-Reviewe=
r: Lars Volker <lv@cloudera=2Ecom>
Gerrit-Reviewer: Laszlo Gaal <laszlo=2Eg=
aal@cloudera=2Ecom>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera=2Ecom>
G=
errit-Reviewer: Philip Zeyliger <philip@cloudera=2Ecom>
Gerrit-Reviewer: Sa=
ilesh Mukil <sailesh@cloudera=2Ecom>
Gerrit-Comment-Date: Tue, 17 Oct 2017 =
23:09:08 +0000
Gerrit-HasComments: Yes

--LRmrnUc3auE=--