Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4C7B0200D2E for ; Tue, 17 Oct 2017 05:48:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4B20B160BE9; Tue, 17 Oct 2017 03:48:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 89FB71609EF for ; Tue, 17 Oct 2017 05:48:08 +0200 (CEST) Received: (qmail 74202 invoked by uid 500); 17 Oct 2017 03:48:07 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 74041 invoked by uid 99); 17 Oct 2017 03:48:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Oct 2017 03:48:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3247418081C for ; Tue, 17 Oct 2017 03:48:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id LnVbZ-qPQORh for ; Tue, 17 Oct 2017 03:48:05 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D51AD5F239 for ; Tue, 17 Oct 2017 03:48:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9H3m3qC025251; Tue, 17 Oct 2017 03:48:03 GMT Message-Id: <201710170348.v9H3m3qC025251@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 1 Date: Tue, 17 Oct 2017 03:48:03 +0000 From: "Pranay Singh (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5142_EventSequence_displays_negative_elapsed_time=2E=0A?= X-Gerrit-Change-Id: I8c944396d96473b17b453da3e913ffc56680a896 X-Gerrit-Change-Number: 8215 X-Gerrit-ChangeURL: X-Gerrit-Commit: 01adb56de9e065416ef48b9ce354fb5c86893222 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 17 Oct 2017 03:48:03 +0000 Reply-To: impala-cr@cloudera.com, marcelk@gmail.com, dhecht@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="8Hra9cfsBdI="; charset=UTF-8 archived-at: Tue, 17 Oct 2017 03:48:09 -0000 --8Hra9cfsBdI= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Pranay Singh has posted comments on this change=2E ( http://gerrit=2Ecloude= ra=2Eorg:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays ne= gative elapsed time=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E Patch Set 1: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/= #/c/8215/1//COMMIT_MSG Commit Message: http://gerrit=2Ecloudera=2Eorg:8080= /#/c/8215/1//COMMIT_MSG@22 PS1, Line 22: value=2E > but the code isn't sync= hronized at all, so you could (in theory) read a gar That's right since the= code not synchronized we can read a garbage start_ which is the case here= =2EI was wondering wether there will be performance overhead if lock is use= d to seialize=2E So instead of printing a negative value I'm printing 0=2E = The Start() is called from ClientRequestState() ClientRequestState::Clie= ntRequestState() { = = query_events_ =3D summary_profile_->AddEventSequence("Query Time= line");=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7= =C2=B7=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7=C2=B7 query_events_->Start(); = } wherea= s ElapsedTime() RuntimeProfile::EventSequence::MarkEvent() = { = sw_=2EElapsedTime()= ; } --= To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8215 To unsubscribe, v= isit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-A= SF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c9= 44396d96473b17b453da3e913ffc56680a896 Gerrit-Change-Number: 8215 Gerrit-Pat= chSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Tue, 17 Oct = 2017 03:48:03 +0000 Gerrit-HasComments: Yes --8Hra9cfsBdI=--