Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9471B200D2E for ; Tue, 17 Oct 2017 02:16:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 92EB5160BE9; Tue, 17 Oct 2017 00:16:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8EFB1609EF for ; Tue, 17 Oct 2017 02:16:51 +0200 (CEST) Received: (qmail 75378 invoked by uid 500); 17 Oct 2017 00:16:51 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 75367 invoked by uid 99); 17 Oct 2017 00:16:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Oct 2017 00:16:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0D3511A2A64 for ; Tue, 17 Oct 2017 00:16:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 3sDns2c25Iun for ; Tue, 17 Oct 2017 00:16:48 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 26F2F5F3CE for ; Tue, 17 Oct 2017 00:16:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9H0GkCZ019483; Tue, 17 Oct 2017 00:16:46 GMT Message-Id: <201710170016.v9H0GkCZ019483@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 1 Date: Tue, 17 Oct 2017 00:16:45 +0000 From: "Dan Hecht (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5142_EventSequence_displays_negative_elapsed_time=2E=0A?= X-Gerrit-Change-Id: I8c944396d96473b17b453da3e913ffc56680a896 X-Gerrit-Change-Number: 8215 X-Gerrit-ChangeURL: X-Gerrit-Commit: 01adb56de9e065416ef48b9ce354fb5c86893222 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 17 Oct 2017 00:16:45 +0000 Reply-To: dhecht@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="6HHbiczpE+Y="; charset=UTF-8 archived-at: Tue, 17 Oct 2017 00:16:52 -0000 --6HHbiczpE+Y= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dan Hecht has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/8215 ) Change subject: IMPALA-5142 EventSequence displays nega= tive elapsed time=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 1: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c= /8215/1//COMMIT_MSG Commit Message: http://gerrit=2Ecloudera=2Eorg:8080/#/= c/8215/1//COMMIT_MSG@22 PS1, Line 22: value=2E but the code isn't synchroni= zed at all, so you could (in theory) read a garbage start_ if it's being mo= dified concurrently=2E What are the callsites of Start() and ElapsedTime(= ) in question? -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/82= 15 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerr= it-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Ge= rrit-Change-Id: I8c944396d96473b17b453da3e913ffc56680a896 Gerrit-Change-Num= ber: 8215 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Da= n Hecht Gerrit-Comment-Date: Tue, 17 Oct 2017 00:16= :45 +0000 Gerrit-HasComments: Yes --6HHbiczpE+Y=--