Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 48A30200D2E for ; Tue, 17 Oct 2017 01:28:34 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 471F5160BE9; Mon, 16 Oct 2017 23:28:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8D4671609EF for ; Tue, 17 Oct 2017 01:28:33 +0200 (CEST) Received: (qmail 84018 invoked by uid 500); 16 Oct 2017 23:28:32 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 84007 invoked by uid 99); 16 Oct 2017 23:28:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Oct 2017 23:28:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B73B11807EB for ; Mon, 16 Oct 2017 23:28:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id PFmaBx5hCjab for ; Mon, 16 Oct 2017 23:28:30 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id EE2EB5F30B for ; Mon, 16 Oct 2017 23:28:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9GNSRdF014803; Mon, 16 Oct 2017 23:28:27 GMT Message-Id: <201710162328.v9GNSRdF014803@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Mon, 16 Oct 2017 23:28:27 +0000 From: "Philip Zeyliger (Code Review)" To: Bikramjeet Vig , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong , anujphadke X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6002=3A_Add_a_LLVM_diagnostic_handler_for_LLVM_linker_errors=0A?= X-Gerrit-Change-Id: I907ff1f8975c02d422b4a669afbfc2e536ddf1ff X-Gerrit-Change-Number: 8233 X-Gerrit-ChangeURL: X-Gerrit-Commit: a8f3c0d06d6529d1ed90936700e3505d7e0322f7 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 16 Oct 2017 23:28:27 +0000 Reply-To: philip@cloudera.com, impala-cr@cloudera.com, aphadke@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, reviews@impala.incubator.apache.org, bikramjeet.vig@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="100aK/4spZE="; charset=UTF-8 archived-at: Mon, 16 Oct 2017 23:28:34 -0000 --100aK/4spZE= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Philip Zeyliger has posted comments on this change=2E ( http://gerrit=2Eclo= udera=2Eorg:8080/8233 ) Change subject: IMPALA-6002: Add a LLVM diagnostic= handler for LLVM linker errors =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E Patch Set 4: Code-Review+1 (2 comments) Thanks! htt= p://gerrit=2Ecloudera=2Eorg:8080/#/c/8233/4/be/src/codegen/llvm-codegen=2Ec= c File be/src/codegen/llvm-codegen=2Ecc: http://gerrit=2Ecloudera=2Eorg:80= 80/#/c/8233/4/be/src/codegen/llvm-codegen=2Ecc@308 PS4, Line 308: if (!= diagnostic_err=2Eempty()) ss <<" "<< diagnostic_err; nit: Do we do spacing = around "<<" operators? http://gerrit=2Ecloudera=2Eorg:8080/#/c/8233/4/be/= src/codegen/llvm-codegen=2Ecc@1625 PS4, Line 1625: diagnostic_printer <= <"LLVM diagnostic error: "; nit: space around "<<"? -- To view, visit h= ttp://gerrit=2Ecloudera=2Eorg:8080/8233 To unsubscribe, visit http://gerrit= =2Ecloudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: = master Gerrit-MessageType: comment Gerrit-Change-Id: I907ff1f8975c02d422b4a= 669afbfc2e536ddf1ff Gerrit-Change-Number: 8233 Gerrit-PatchSet: 4 Gerrit-Ow= ner: Bikramjeet Vig Gerrit-Reviewer: Bikr= amjeet Vig Gerrit-Reviewer: Philip Zeylig= er Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: anujphadke Gerrit-Comm= ent-Date: Mon, 16 Oct 2017 23:28:27 +0000 Gerrit-HasComments: Yes --100aK/4spZE=--