Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A75EB200D2A for ; Sat, 14 Oct 2017 00:50:24 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A5A27160BE5; Fri, 13 Oct 2017 22:50:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EB9671609E9 for ; Sat, 14 Oct 2017 00:50:23 +0200 (CEST) Received: (qmail 70677 invoked by uid 500); 13 Oct 2017 22:50:23 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 70662 invoked by uid 99); 13 Oct 2017 22:50:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Oct 2017 22:50:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1FB34C6843 for ; Fri, 13 Oct 2017 22:50:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.363 X-Spam-Level: ** X-Spam-Status: No, score=2.363 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 797S4HeAgC7W for ; Fri, 13 Oct 2017 22:50:21 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 362885FAF3 for ; Fri, 13 Oct 2017 22:50:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9DMoJ3F017969; Fri, 13 Oct 2017 22:50:19 GMT Message-Id: <201710132250.v9DMoJ3F017969@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 8 Date: Fri, 13 Oct 2017 22:50:19 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Joe McDonnell , Bikramjeet Vig X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5522=3AUse_tracked_memory_for_DictDecoder_and_DictEncoder=0A?= X-Gerrit-Change-Id: I02a3b54f6c107d19b62ad9e1c49df94175964299 X-Gerrit-Change-Number: 8034 X-Gerrit-ChangeURL: X-Gerrit-Commit: 21269e5a0a197f604fbfa40a95324fa9dffff471 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 13 Oct 2017 22:50:19 +0000 Reply-To: tarmstrong@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, joemcdonnell@cloudera.com, reviews@impala.incubator.apache.org, bikramjeet.vig@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="erIQ62oDEqc="; charset=UTF-8 archived-at: Fri, 13 Oct 2017 22:50:24 -0000 --erIQ62oDEqc= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Tim Armstrong has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for D= ictDecoder and DictEncoder =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E Patch Set 8: (1 comment) http://gerrit=2Ecloudera=2Eorg:80= 80/#/c/8034/8/be/src/util/dict-encoding=2Eh File be/src/util/dict-encoding= =2Eh: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8034/8/be/src/util/dict-enco= ding=2Eh@251 PS8, Line 251: ReleaseBytes(); > Checking the dict_bytes_cnt_ = to be zero seems to be tricky say even if it i I agree with Joe's comment= =2E All codepaths should call Close(), so we can just add a DCHECK here to = enforce that they did so=2E -- To view, visit http://gerrit=2Ecloudera= =2Eorg:8080/8034 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/= settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageTy= pe: comment Gerrit-Change-Id: I02a3b54f6c107d19b62ad9e1c49df94175964299 Ger= rit-Change-Number: 8034 Gerrit-PatchSet: 8 Gerrit-Owner: Pranay Singh Gerri= t-Reviewer: Bikramjeet Vig Gerrit-Reviewe= r: Joe McDonnell Gerrit-Reviewer: Pranay Sing= h Gerrit-Reviewer: Tim Armstrong Gerrit-Comment= -Date: Fri, 13 Oct 2017 22:50:19 +0000 Gerrit-HasComments: Yes --erIQ62oDEqc=--