Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201710131654.v9DGsYGt010124@ip-10-146-233-104.ec2.internal>
Date: Fri, 13 Oct 2017 16:54:34 +0000
From: "Philip Zeyliger (Code Review)" <gerrit@cloudera.org>
To: Jim Apple <jbapple-impala@apache.org>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Lars Volker <lv@cloudera.com>, Michael Brown <mikeb@cloudera.com>,
        Zoram Thanga <zoram@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-6045=3A_Make_build_scripts_more_friendly_to_Ubuntu_16=2E04=0A?=
In-Reply-To: <gerrit.1507783359000.I8196a2a87bce5893a349a1b290c3f3d04fd80317@gerrit.cloudera.org>
References: <gerrit.1507783359000.I8196a2a87bce5893a349a1b290c3f3d04fd80317@gerrit.cloudera.org>
Reply-To: philip@cloudera.com, impala-cr@cloudera.com, lv@cloudera.com,
        marcelk@gmail.com, zoram@cloudera.com, jbapple-impala@apache.org,
        reviews@impala.incubator.apache.org, mikeb@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="E1vH9iDojzQ="; charset=UTF-8
archived-at: Fri, 13 Oct 2017 16:54:42 -0000

--E1vH9iDojzQ=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Philip Zeyliger has posted comments on this change=2E ( http://gerrit=2Eclo=
udera=2Eorg:8080/8262 )

Change subject: IMPALA-6045: Make build scripts mo=
re friendly to Ubuntu 16=2E04
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E


Patch Set 3:

(2 comments)

Sorry to get to this a bit la=
te=2E

I find the distinctions between the (now 3) bootstrap_* scripts to b=
e really hard to grok=2E Since we're multiplying scripts in this commit, it=
 seems like we should clarify those distinctions=2E

I very much like separ=
ating bootstrap_system from bootstrap_development, but I think it doesn't m=
ake sense to separate it into two scripts=2E Rather, I think this would be =
clearer to use if it looked like:

  bootstrap_development  [install-packag=
es] [checkout-impala] [configure] [build] [loadtestdata] [runtests]

(Or so=
mething like it; point being to have on entry point with a few variants=2E)=


The default actions would be whatever bootstrap_development does today=2E=


There's a mild prototype at https://github=2Ecom/philz/incubator-impala/c=
ommit/e0e7ad3ce07335709987b1b4088ac66ef312e7af if you're interested=2E This=
 came up for me while trying to time the different parts of the bootstrap s=
cript for some Docker work I was doing=2E In it, I just broke the existing =
script into ~5 bash functions=2E

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8=
262/3/bin/bootstrap_build=2Esh
File bin/bootstrap_build=2Esh:

http://gerri=
t=2Ecloudera=2Eorg:8080/#/c/8262/3/bin/bootstrap_build=2Esh@35
PS3, Line 35=
:     python-dev python-setuptools libffi-dev libkrb5-dev
Consider just add=
ing openjdk-${JDK_VERSION}-jdk (and friends) here? I don't know that one ap=
t-get command is faster than two, but it's nice to have them all together=
=2E


http://gerrit=2Ecloudera=2Eorg:8080/#/c/8262/3/bin/bootstrap_system=
=2Esh
File bin/bootstrap_system=2Esh:

http://gerrit=2Ecloudera=2Eorg:8080/=
#/c/8262/3/bin/bootstrap_system=2Esh@20
PS3, Line 20: # This script bootstr=
aps a system for Impala development from almost nothing; it is known
This i=
s very heavily replicated with bootstrap_development; highlighting the diff=
erences may make sense=2E


-- 
To view, visit http://gerrit=2Ecloudera=2E=
org:8080/8262
To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/set=
tings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType:=
 comment
Gerrit-Change-Id: I8196a2a87bce5893a349a1b290c3f3d04fd80317
Gerrit=
-Change-Number: 8262
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jbapple-im=
pala@apache=2Eorg>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache=2Eorg>=

Gerrit-Reviewer: Lars Volker <lv@cloudera=2Ecom>
Gerrit-Reviewer: Michael =
Brown <mikeb@cloudera=2Ecom>
Gerrit-Reviewer: Philip Zeyliger <philip@cloud=
era=2Ecom>
Gerrit-Reviewer: Zoram Thanga <zoram@cloudera=2Ecom>
Gerrit-Comm=
ent-Date: Fri, 13 Oct 2017 16:54:34 +0000
Gerrit-HasComments: Yes

--E1vH9iDojzQ=--