Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 70B04200D29 for ; Thu, 12 Oct 2017 00:06:18 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6F5F3160BE3; Wed, 11 Oct 2017 22:06:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B46451609E5 for ; Thu, 12 Oct 2017 00:06:17 +0200 (CEST) Received: (qmail 68037 invoked by uid 500); 11 Oct 2017 22:06:16 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 68026 invoked by uid 99); 11 Oct 2017 22:06:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Oct 2017 22:06:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E5D9C1A11B8 for ; Wed, 11 Oct 2017 22:06:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id maWBogaZzdM7 for ; Wed, 11 Oct 2017 22:06:14 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 337FF5FB4E for ; Wed, 11 Oct 2017 22:06:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9BM6B5K012064; Wed, 11 Oct 2017 22:06:11 GMT Message-Id: <201710112206.v9BM6B5K012064@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 7 Date: Wed, 11 Oct 2017 22:06:11 +0000 From: "Michael Ho (Code Review)" To: Sailesh Mukil , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Bikramjeet Vig , Dan Hecht X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5129=3A_Use_KRPC=27s_Kinit_code_to_avoid_expensive_fork=0A?= X-Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7 X-Gerrit-Change-Number: 7938 X-Gerrit-ChangeURL: X-Gerrit-Commit: 35cf9a6f13dcb99b0126be7306c7363e21969b3b In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 11 Oct 2017 22:06:11 +0000 Reply-To: kwho@cloudera.com, impala-cr@cloudera.com, sailesh@cloudera.com, marcelk@gmail.com, dhecht@cloudera.com, reviews@impala.incubator.apache.org, bikramjeet.vig@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="HzCfdVwm1Io="; charset=UTF-8 archived-at: Wed, 11 Oct 2017 22:06:18 -0000 --HzCfdVwm1Io= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Michael Ho has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to a= void expensive fork =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 7: (2 comments) http://gerrit=2Ecloudera=2Eorg:8080/#/= c/7938/7/be/src/rpc/thrift-server-test=2Ecc File be/src/rpc/thrift-server-t= est=2Ecc: http://gerrit=2Ecloudera=2Eorg:8080/#/c/7938/7/be/src/rpc/thrift= -server-test=2Ecc@96 PS7, Line 96: int kdc_port =3D GetServerPort(); static= http://gerrit=2Ecloudera=2Eorg:8080/#/c/7938/7/be/src/rpc/thrift-server-= test=2Ecc@247 PS7, Line 247: As discussed offline, may be it'd help to tes= t with short renewal period to exercise the renewal path too if possible=2E= -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/7938 To unsubscr= ibe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Im= pala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id= : I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7 Gerrit-Change-Number: 7938 Gerr= it-PatchSet: 7 Gerrit-Owner: Sailesh Mukil Gerrit-= Reviewer: Bikramjeet Vig Gerrit-Reviewer:= Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Co= mment-Date: Wed, 11 Oct 2017 22:06:11 +0000 Gerrit-HasComments: Yes --HzCfdVwm1Io=--