Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DA77F200D27 for ; Wed, 11 Oct 2017 02:52:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D8F88160BE1; Wed, 11 Oct 2017 00:52:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2AF53160BE0 for ; Wed, 11 Oct 2017 02:52:00 +0200 (CEST) Received: (qmail 6708 invoked by uid 500); 11 Oct 2017 00:51:59 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 6697 invoked by uid 99); 11 Oct 2017 00:51:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Oct 2017 00:51:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 536C619550B for ; Wed, 11 Oct 2017 00:51:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id V_XEjhBJLcWz for ; Wed, 11 Oct 2017 00:51:57 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 3AA685FDDC for ; Wed, 11 Oct 2017 00:51:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9B0prt9027535; Wed, 11 Oct 2017 00:51:53 GMT Message-Id: <201710110051.v9B0prt9027535@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 6 Date: Wed, 11 Oct 2017 00:51:53 +0000 From: "Michael Ho (Code Review)" To: Sailesh Mukil , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Bikramjeet Vig X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5129=3A_Use_KRPC=27s_Kinit_code_to_avoid_expensive_fork=0A?= X-Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a2f91ea6af6c7 X-Gerrit-Change-Number: 7938 X-Gerrit-ChangeURL: X-Gerrit-Commit: b3b724fb1ff08caa0baf4b808e4d5c9f0d80b4fe In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 11 Oct 2017 00:51:53 +0000 Reply-To: kwho@cloudera.com, impala-cr@cloudera.com, sailesh@cloudera.com, marcelk@gmail.com, reviews@impala.incubator.apache.org, bikramjeet.vig@cloudera.com, dhecht@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="7giqMS4muEU="; charset=UTF-8 archived-at: Wed, 11 Oct 2017 00:52:01 -0000 --7giqMS4muEU= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Michael Ho has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/7938 ) Change subject: IMPALA-5129: Use KRPC's Kinit code to a= void expensive fork =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E Patch Set 6: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c= /7938/6/be/src/exec/kudu-util=2Eh File be/src/exec/kudu-util=2Eh: http://g= errit=2Ecloudera=2Eorg:8080/#/c/7938/6/be/src/exec/kudu-util=2Eh@45 PS6, Li= ne 45: Status& > Should this be Status instead of Status& ? Nevermind=2E Us= ing const reference is fine too=2E The returned object's lifetime is extend= ed to that of the reference although I would expect the compiler to figure = it out too even without using a reference=2E -- To view, visit http://g= errit=2Ecloudera=2Eorg:8080/7938 To unsubscribe, visit http://gerrit=2Eclou= dera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master = Gerrit-MessageType: comment Gerrit-Change-Id: I9cea56cc6e7412d87f4c2e92399a= 2f91ea6af6c7 Gerrit-Change-Number: 7938 Gerrit-PatchSet: 6 Gerrit-Owner: Sa= ilesh Mukil Gerrit-Reviewer: Bikramjeet Vig Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sail= esh Mukil Gerrit-Comment-Date: Wed, 11 Oct 2017 00= :51:53 +0000 Gerrit-HasComments: Yes --7giqMS4muEU=--