Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E7BBA200D16 for ; Tue, 10 Oct 2017 19:54:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E4B58160BE0; Tue, 10 Oct 2017 17:54:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3627B1609CB for ; Tue, 10 Oct 2017 19:54:16 +0200 (CEST) Received: (qmail 20982 invoked by uid 500); 10 Oct 2017 17:54:15 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 20970 invoked by uid 99); 10 Oct 2017 17:54:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Oct 2017 17:54:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5D674D9B4C for ; Tue, 10 Oct 2017 17:54:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id y_awMfO9xntg for ; Tue, 10 Oct 2017 17:54:12 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BAC565F39D for ; Tue, 10 Oct 2017 17:54:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v9AHs9Tk012323; Tue, 10 Oct 2017 17:54:09 GMT Message-Id: <201710101754.v9AHs9Tk012323@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 15 Date: Tue, 10 Oct 2017 17:54:09 +0000 From: "Dan Hecht (Code Review)" To: Tianyi Wang , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Lars Volker , Tim Armstrong , Alex Behm X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5425=3A_Add_test_for_validating_input_when_setting_query_options=0A?= X-Gerrit-Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7 X-Gerrit-Change-Number: 7805 X-Gerrit-ChangeURL: X-Gerrit-Commit: 07e7eeec9dc974e3978416f25288ed56eeff33f1 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 10 Oct 2017 17:54:09 +0000 Reply-To: dhecht@cloudera.com, impala-cr@cloudera.com, twang@cloudera.com, lv@cloudera.com, marcelk@gmail.com, tarmstrong@cloudera.com, alex.behm@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="x+R5d7E2u+U="; charset=UTF-8 archived-at: Tue, 10 Oct 2017 17:54:17 -0000 --x+R5d7E2u+U= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Dan Hecht has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/7805 ) Change subject: IMPALA-5425: Add test for validating in= put when setting query options =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E Patch Set 15: Code-Review+2 -- To view, visit http:= //gerrit=2Ecloudera=2Eorg:8080/7805 To unsubscribe, visit http://gerrit=2Ec= loudera=2Eorg:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: mast= er Gerrit-MessageType: comment Gerrit-Change-Id: I510e02bb0776673d8cbfc22b9= 03831882c6908d7 Gerrit-Change-Number: 7805 Gerrit-PatchSet: 15 Gerrit-Owner= : Tianyi Wang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit= -Reviewer: Lars Volker Gerrit-Reviewer: Tianyi Wang Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 10 Oct 2017 17:54:09 +0000 Gerrit-HasComments= : No --x+R5d7E2u+U=--