Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201710100041.v9A0fuw3001740@ip-10-146-233-104.ec2.internal>
Date: Tue, 10 Oct 2017 00:41:56 +0000
From: "Taras Bobrovytsky (Code Review)" <gerrit@cloudera.org>
To: anujphadke <aphadke@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>, Michael Brown <mikeb@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4848=3A_Add_WIDTH_BUCKET=28=29_function=0A?=
In-Reply-To: <gerrit.1487202122000.I081bc916b1bef7b929ca161a9aade3b54c6b858f@gerrit.cloudera.org>
References: <gerrit.1487202122000.I081bc916b1bef7b929ca161a9aade3b54c6b858f@gerrit.cloudera.org>
Reply-To: tbobrovytsky@cloudera.com, impala-cr@cloudera.com,
        aphadke@cloudera.com, marcelk@gmail.com, alex.behm@cloudera.com,
        reviews@impala.incubator.apache.org, mikeb@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="ooruu00pOg8="; charset=UTF-8
archived-at: Tue, 10 Oct 2017 00:42:03 -0000

--ooruu00pOg8=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Taras Bobrovytsky has posted comments on this change=2E ( http://gerrit=2Ec=
loudera=2Eorg:8080/6023 )

Change subject: IMPALA-4848: Add WIDTH_BUCKET() =
function
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E


Pat=
ch Set 7:

(4 comments)

http://gerrit=2Ecloudera=2Eorg:8080/#/c/6023/7/be/=
src/exprs/expr-test=2Ecc
File be/src/exprs/expr-test=2Ecc:

http://gerrit=
=2Ecloudera=2Eorg:8080/#/c/6023/7/be/src/exprs/expr-test=2Ecc@4247
PS7, Lin=
e 4247:   TestValue("width_bucket(6=2E3, 2, 17, 2)", TYPE_BIGINT, 1);
You s=
hould include a case like (10000, 1, 6, 3)


http://gerrit=2Ecloudera=2Eorg=
:8080/#/c/6023/7/be/src/exprs/math-functions-ir=2Ecc
File be/src/exprs/math=
-functions-ir=2Ecc:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/6023/7/be/src/=
exprs/math-functions-ir=2Ecc@429
PS7, Line 429: bucket_width
This should be=
 called bucket_number to make it more clear


http://gerrit=2Ecloudera=2Eor=
g:8080/#/c/6023/7/be/src/exprs/math-functions-ir=2Ecc@431
PS7, Line 431: wi=
dth_size
width_size is a confusing name=2E This should be called something =
like "distance_from_min"=2E


http://gerrit=2Ecloudera=2Eorg:8080/#/c/6023/=
7/be/src/exprs/math-functions-ir=2Ecc@516
PS7, Line 516:   int256_t x =3D C=
onvertToInt256(buckets=2Evalue()) * ConvertToInt256(width_size=2Evalue());
=
> Won't this require a lot of memory to create such a array?
Sure, that's t=
rue=2E I don't think that this function is meant to be used that way though=
=2E It's difficult to imagine someone wanting to use over 1000 buckets=2E I=
n that case, we could fall back to the current implementation=2E


-- 
To =
view, visit http://gerrit=2Ecloudera=2Eorg:8080/6023
To unsubscribe, visit =
http://gerrit=2Ecloudera=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Ge=
rrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I081bc916=
b1bef7b929ca161a9aade3b54c6b858f
Gerrit-Change-Number: 6023
Gerrit-PatchSet=
: 7
Gerrit-Owner: anujphadke <aphadke@cloudera=2Ecom>
Gerrit-Reviewer: Alex=
 Behm <alex=2Ebehm@cloudera=2Ecom>
Gerrit-Reviewer: Michael Brown <mikeb@cl=
oudera=2Ecom>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera=2Ec=
om>
Gerrit-Reviewer: anujphadke <aphadke@cloudera=2Ecom>
Gerrit-Comment-Dat=
e: Tue, 10 Oct 2017 00:41:56 +0000
Gerrit-HasComments: Yes

--ooruu00pOg8=--