Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 98B8D200D15 for ; Thu, 5 Oct 2017 19:52:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 97CE61609E2; Thu, 5 Oct 2017 17:52:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E544E1609D2 for ; Thu, 5 Oct 2017 19:52:51 +0200 (CEST) Received: (qmail 30187 invoked by uid 500); 5 Oct 2017 17:52:51 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 30176 invoked by uid 99); 5 Oct 2017 17:52:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Oct 2017 17:52:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1D81ACE77B for ; Thu, 5 Oct 2017 17:52:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.362 X-Spam-Level: ** X-Spam-Status: No, score=2.362 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Tf8SAb_Bqra1 for ; Thu, 5 Oct 2017 17:52:48 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 9B00F5F569 for ; Thu, 5 Oct 2017 17:52:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v95Hqk3v025099; Thu, 5 Oct 2017 17:52:46 GMT Message-Id: <201710051752.v95Hqk3v025099@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 4 Date: Thu, 5 Oct 2017 17:52:46 +0000 From: "Vuk Ercegovac (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Balazs Jeszenszky , Philip Zeyliger X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4704=3A_Disallow_client_connections_to_imapalad_until_catalog_is_received=2E=0A?= X-Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 X-Gerrit-Change-Number: 8202 X-Gerrit-ChangeURL: X-Gerrit-Commit: efe426b40803700cc52e5fc3aef746a0c7d7c723 In-Reply-To: References: X-Gerrit-Comment-Date: Thu, 5 Oct 2017 17:52:46 +0000 Reply-To: vercegovac@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, philip@cloudera.com, reviews@impala.incubator.apache.org, jeszyb@gmail.com, dhecht@cloudera.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="ZqETJMZs73E="; charset=UTF-8 archived-at: Thu, 05 Oct 2017 17:52:52 -0000 --ZqETJMZs73E= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Vuk Ercegovac has posted comments on this change=2E ( http://gerrit=2Ecloud= era=2Eorg:8080/8202 ) Change subject: IMPALA-4704: Disallow client connect= ions to imapalad until catalog is received=2E =2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Patch Set 4: (2 comments) http://gerr= it=2Ecloudera=2Eorg:8080/#/c/8202/3/be/src/testutil/in-process-servers=2Ecc= File be/src/testutil/in-process-servers=2Ecc: http://gerrit=2Ecloudera=2E= org:8080/#/c/8202/3/be/src/testutil/in-process-servers=2Ecc@75 PS3, Line 75= : if (started=2Eok()) return impala; > You're no longer logging status= =2EgetDetail() any more=2E I suspect that's inte prev=2E code only logged f= or the set-catalog case, which was odd=2E I've added logging now for all br= anches that return a not-ok status=2E http://gerrit=2Ecloudera=2Eorg:8080= /#/c/8202/3/tests/custom_cluster/test_catalog_wait=2Epy File tests/custom_c= luster/test_catalog_wait=2Epy: http://gerrit=2Ecloudera=2Eorg:8080/#/c/820= 2/3/tests/custom_cluster/test_catalog_wait=2Epy@26 PS3, Line 26: > nit: wh= itespace? Done -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/82= 02 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerr= it-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Ge= rrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6 Gerrit-Change-Num= ber: 8202 Gerrit-PatchSet: 4 Gerrit-Owner: Vuk Ercegovac Gerrit-Reviewer: Balazs Jeszenszky Gerrit-Re= viewer: Dan Hecht Gerrit-Reviewer: Philip Zeyliger = Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Thu, 05 Oct 2017 17:52:46 +0000 Gerrit-HasComm= ents: Yes --ZqETJMZs73E=--