Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201710032157.v93LvWVh010559@ip-10-146-233-104.ec2.internal>
Date: Tue, 3 Oct 2017 21:57:32 +0000
From: "Thomas Tauber-Marshall (Code Review)" <gerrit@cloudera.org>
To: John Russell <jrussell@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Todd Lipcon <todd@apache.org>, Greg Rahn <grahn@cloudera.com>,
        Ambreen Kazi <ambreen.kazi@cloudera.com>
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4622=3A_=5BDOCS=5D_New_Kudu_ALTER_TABLE_syntax=0A?=
In-Reply-To: <gerrit.1506928124000.I7647dfe8acfdb598caf561d41d74e38a8b66ce9d@gerrit.cloudera.org>
References: <gerrit.1506928124000.I7647dfe8acfdb598caf561d41d74e38a8b66ce9d@gerrit.cloudera.org>
Reply-To: tmarshall@cloudera.com, jrussell@cloudera.com,
        impala-cr@cloudera.com, marcelk@gmail.com, todd@apache.org,
        reviews@impala.incubator.apache.org, grahn@cloudera.com,
        ambreen.kazi@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="IBegDfaC1L0="; charset=UTF-8
archived-at: Tue, 03 Oct 2017 21:57:37 -0000

--IBegDfaC1L0=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Thomas Tauber-Marshall has posted comments on this change=2E ( http://gerri=
t=2Ecloudera=2Eorg:8080/8191 )

Change subject: IMPALA-4622: [DOCS] New Kud=
u ALTER TABLE syntax
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E


Patch Set 2:

(4 comments)

http://gerrit=2Ecloudera=2Eorg:8080/#/=
c/8191/2/docs/topics/impala_alter_table=2Exml
File docs/topics/impala_alter=
_table=2Exml:

http://gerrit=2Ecloudera=2Eorg:8080/#/c/8191/2/docs/topics/i=
mpala_alter_table=2Exml@67
PS2, Line 67: ]
extraneous?


http://gerrit=2Ecl=
oudera=2Eorg:8080/#/c/8191/2/docs/topics/impala_alter_table=2Exml@69
PS2, L=
ine 69: COMMENT '<varname>comment_text</varname>'
This does parse, but it w=
ill always give an error because Kudu doesn't support column comments=2E


=
http://gerrit=2Ecloudera=2Eorg:8080/#/c/8191/2/docs/topics/impala_alter_tab=
le=2Exml@71
PS2, Line 71: {
missing the closing '}'


http://gerrit=2Ecloud=
era=2Eorg:8080/#/c/8191/2/docs/topics/impala_alter_table=2Exml@1038
PS2, Li=
ne 1038: any newly inserted rows
These attributes may in some cases end up =
applied to existing rows as Kudu performs compactions=2E Not sure if that s=
hould be noted here=2E


-- 
To view, visit http://gerrit=2Ecloudera=2Eorg=
:8080/8191
To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080/settin=
gs

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: co=
mment
Gerrit-Change-Id: I7647dfe8acfdb598caf561d41d74e38a8b66ce9d
Gerrit-Ch=
ange-Number: 8191
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jrussell@c=
loudera=2Ecom>
Gerrit-Reviewer: Ambreen Kazi <ambreen=2Ekazi@cloudera=2Ecom=
>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera=2Ecom>
Gerrit-Reviewer: Thomas=
 Tauber-Marshall <tmarshall@cloudera=2Ecom>
Gerrit-Reviewer: Todd Lipcon <t=
odd@apache=2Eorg>
Gerrit-Comment-Date: Tue, 03 Oct 2017 21:57:32 +0000
Gerr=
it-HasComments: Yes

--IBegDfaC1L0=--