Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BFD7D200D14 for ; Tue, 3 Oct 2017 21:00:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BE8091609DE; Tue, 3 Oct 2017 19:00:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0FAE71609BD for ; Tue, 3 Oct 2017 21:00:05 +0200 (CEST) Received: (qmail 32394 invoked by uid 500); 3 Oct 2017 19:00:04 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 32383 invoked by uid 99); 3 Oct 2017 19:00:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Oct 2017 19:00:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D2FEB1A2218 for ; Tue, 3 Oct 2017 19:00:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.363 X-Spam-Level: ** X-Spam-Status: No, score=2.363 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id LzvvUlpYVlD5 for ; Tue, 3 Oct 2017 19:00:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D20415F3D1 for ; Tue, 3 Oct 2017 19:00:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v93Ixx5f002964; Tue, 3 Oct 2017 18:59:59 GMT Message-Id: <201710031859.v93Ixx5f002964@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 3 Date: Tue, 3 Oct 2017 18:59:59 +0000 From: "Bikramjeet Vig (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Joe McDonnell X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5522=3AUse_tracked_memory_for_DictDecoder_and_DictEncoder=0A?= X-Gerrit-Change-Id: I02a3b54f6c107d19b62ad9e1c49df94175964299 X-Gerrit-Change-Number: 8034 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6cc7d97ffcd777b9f2b55f734c2585fa4b6c10a6 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 3 Oct 2017 18:59:59 +0000 Reply-To: bikramjeet.vig@cloudera.com, impala-cr@cloudera.com, marcelk@gmail.com, joemcdonnell@cloudera.com, reviews@impala.incubator.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.2 Content-Type: multipart/alternative; boundary="UJ2dkkKI81w="; charset=UTF-8 archived-at: Tue, 03 Oct 2017 19:00:06 -0000 --UJ2dkkKI81w= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Bikramjeet Vig has posted comments on this change=2E ( http://gerrit=2Eclou= dera=2Eorg:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for = DictDecoder and DictEncoder =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E Patch Set 3: (1 comment) http://gerrit=2Ecloudera=2Eorg= :8080/#/c/8034/3/be/src/util/dict-encoding=2Eh File be/src/util/dict-encodi= ng=2Eh: http://gerrit=2Ecloudera=2Eorg:8080/#/c/8034/3/be/src/util/dict-en= coding=2Eh@412 PS3, Line 412: ConsumeBytes(sizeof(value)); > For strings, t= he StringValue is a pointer and a length=2E In the case of the yes I agree= -- To view, visit http://gerrit=2Ecloudera=2Eorg:8080/8034 To unsubscr= ibe, visit http://gerrit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: Im= pala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id= : I02a3b54f6c107d19b62ad9e1c49df94175964299 Gerrit-Change-Number: 8034 Gerr= it-PatchSet: 3 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bikramjeet Vig <= bikramjeet=2Evig@cloudera=2Ecom> Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Tue, = 03 Oct 2017 18:59:59 +0000 Gerrit-HasComments: Yes --UJ2dkkKI81w=--