Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201710022317.v92NHJxH021502@ip-10-146-233-104.ec2.internal>
Date: Mon, 2 Oct 2017 23:17:19 +0000
From: "John Sherman (Code Review)" <gerrit@cloudera.org>
To: Henry Robinson <henry@cloudera.com>, Matthew Jacobs <mjacobs@apache.org>,
        Sailesh Mukil <sailesh@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-5394=3A_Change_ThriftServer=28=29_to_always_use_TAcceptQueueServer=0A?=
In-Reply-To: <gerrit.1496426620000.I56a5f3d9cf931cff14eae7f236fea018236a6255@gerrit.cloudera.org>
References: <gerrit.1496426620000.I56a5f3d9cf931cff14eae7f236fea018236a6255@gerrit.cloudera.org>
Reply-To: jfs@arcadiadata.com, impala-cr@cloudera.com, sailesh@cloudera.com,
        marcelk@gmail.com, henry@cloudera.com,
        reviews@impala.incubator.apache.org, mjacobs@apache.org,
        dhecht@cloudera.com
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.14.2
Content-Type: multipart/alternative; boundary="x/g5ClOoGMs="; charset=UTF-8
archived-at: Mon, 02 Oct 2017 23:17:27 -0000

--x/g5ClOoGMs=
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Henry Robinson, Matthew Jacobs, Sailesh Mukil, Dan Hecht, 

I'd like =
you to reexamine a change=2E Please visit

    http://gerrit=2Ecloudera=2Eo=
rg:8080/7061

to look at the new patch set (#9)=2E

Change subject: IMPALA-=
5394: Change ThriftServer() to always use TAcceptQueueServer
=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=
=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E

IMPALA-5394: Change Thrif=
tServer() to always use TAcceptQueueServer

- Previously TThreadPoolServer =
called getTransport() on a client from
  the Server thread (the thread that=
 did the accepts)=2E
  - TSaslServerTransport->getTransport() called TSaslT=
ransport->open()
  - TSaslServerTransport->open() tried to negotiate SASL w=
hich calls
    read/write
    - If read/write blocks indefinitely, the TThr=
eadPoolServer could
      not accept connections until tcp_keepalive kicked=
 in=2E
- Set the underlying TSocket's recvTimeout and sendTimeout before th=
e
  TSaslServerTransport->open() and reset them to 0 after open()
  complet=
es=2E
- Added sasl_connect_tcp_timeout_ms flag that defaults to 300000
  mi=
lliseconds (5 minutes)
- Add the ability for TAcceptQueueServer to limit th=
e maximum
  number of concurrent tasks
- Added a test case to thrift-server=
-test to test
  max_concurrent_connections enforcement
- Changed the remain=
ing Thrift servers to use TAcceptQueueServer=2E
  (hs2/beeswax/network-perf=
-benchmark)
  - The timeout is still needed in TAcceptQueueServer since
   =
 SetupConnection follows a similar pattern that TThreadPoolServer
    does=
=2E
- Removed support for TThreadPool from ThriftServer() since it is
  no =
longer used anywhere=2E ThriftServer() now always uses
  TAcceptQueueServer=
=2E
- Deprecated enable_accept_queue_server flag and removed supporting
  c=
ode=2E

Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
---
M be/src/b=
enchmarks/network-perf-benchmark=2Ecc
M be/src/common/global-flags=2Ecc
M b=
e/src/rpc/TAcceptQueueServer=2Ecpp
M be/src/rpc/TAcceptQueueServer=2Eh
M be=
/src/rpc/thrift-server-test=2Ecc
M be/src/rpc/thrift-server=2Ecc
M be/src/r=
pc/thrift-server=2Eh
M be/src/service/impala-server=2Ecc
M be/src/transport=
/TSaslServerTransport=2Ecpp
M common/thrift/metrics=2Ejson
10 files changed=
, 159 insertions(+), 112 deletions(-)


  git pull ssh://gerrit=2Ecloudera=
=2Eorg:29418/Impala-ASF refs/changes/61/7061/9
-- 
To view, visit http://ge=
rrit=2Ecloudera=2Eorg:8080/7061
To unsubscribe, visit http://gerrit=2Ecloud=
era=2Eorg:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
G=
errit-MessageType: newpatchset
Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f23=
6fea018236a6255
Gerrit-Change-Number: 7061
Gerrit-PatchSet: 9
Gerrit-Owner:=
 John Sherman <jfs@arcadiadata=2Ecom>
Gerrit-Reviewer: Dan Hecht <dhecht@cl=
oudera=2Ecom>
Gerrit-Reviewer: Henry Robinson <henry@cloudera=2Ecom>
Gerrit=
-Reviewer: John Sherman <jfs@arcadiadata=2Ecom>
Gerrit-Reviewer: Matthew Ja=
cobs <mjacobs@apache=2Eorg>
Gerrit-Reviewer: Sailesh Mukil <sailesh@clouder=
a=2Ecom>

--x/g5ClOoGMs=--