impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Correct log line in start-impala-cluster.py.
Date Tue, 31 Oct 2017 22:39:17 GMT
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8432


Change subject: Correct log line in start-impala-cluster.py.
......................................................................

Correct log line in start-impala-cluster.py.

Updated logging in start-impala-cluster to accurately specify how many
impala nodes were started, and how many of these were coordinators or
executors or both. The new logging looks like:

  Impala Cluster Running with 1 nodes (1 coordinators, 1 executors).

Previously, when invoking this script with --cluster_size=1, it would
report "1 nodes and 3 coordinators" which was wrong (because there was
only 1 coordinator) and confusing (because it seemed like a coordinator
was a separate thing from a node).

I also removed an unused import.

I have run core and exhaustive tests with these change, as part of
testing other changes. Nothing untoward happened.

Change-Id: I7ceece1c05b9a4ca9f0a08fa30d195f811490c0e
---
M bin/start-impala-cluster.py
1 file changed, 8 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/8432/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ceece1c05b9a4ca9f0a08fa30d195f811490c0e
Gerrit-Change-Number: 8432
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message