impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5957: print memory address, not memory
Date Tue, 24 Oct 2017 18:09:41 GMT
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8371


Change subject: IMPALA-5957: print memory address, not memory
......................................................................

IMPALA-5957: print memory address, not memory

The bug is that the pointer was a uint8_t*, which C++ iostreams
print as a C-style string. The intent was to instead print the
memory address, which happens for void*. To avoid the subtlety,
instead convert to uintptr_t and print as hex.

Change-Id: I89250646bf683dd2d636dcb37a66ceb0428af8b2
---
M be/src/runtime/bufferpool/system-allocator.cc
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/8371/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8371
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89250646bf683dd2d636dcb37a66ceb0428af8b2
Gerrit-Change-Number: 8371
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message