impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6076: Parquet BIT PACKED deprecation warning
Date Tue, 24 Oct 2017 17:55:44 GMT
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8370


Change subject: IMPALA-6076: Parquet BIT_PACKED deprecation warning
......................................................................

IMPALA-6076: Parquet BIT_PACKED deprecation warning

Every 100th time that we open a Parquet column with the
deprecated BIT_PACKED encoding, an error is logged. We do this
per-column instead of per-file because Impala historically
listed the BIT_PACKED encoding in file metadata even when it
wasn't used for any columns - see IMPALA-5636.

Testing:
Manually tested by running a query repeatedly against a
BIT_PACKED sample file (which I created for my IMPALA-4177
patch). Ran "tail -f logs/cluster/impalad.WARNING" and checked
that the warning was logged periodically.

Change-Id: I02dd4009089a264b28376492b1b40361d767d5d9
---
M be/src/exec/parquet-column-readers.cc
1 file changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/8370/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02dd4009089a264b28376492b1b40361d767d5d9
Gerrit-Change-Number: 8370
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message