impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Behm <alex.b...@cloudera.com>
Subject Re: [Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
Date Thu, 05 Oct 2017 05:46:59 GMT
Great work, John! Thanks for your continued effort to get this important
change merged. Much appreciated.

On Wed, Oct 4, 2017 at 7:26 PM, Impala Public Jenkins (Code Review) <
gerrit@cloudera.org> wrote:

> Impala Public Jenkins *merged* this change.
>
> View Change <http://gerrit.cloudera.org:8080/7061>
> Approvals: Sailesh Mukil: Looks good to me, approved Impala Public
> Jenkins: Verified
>
> IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
>
> - Previously TThreadPoolServer called getTransport() on a client from
>   the Server thread (the thread that did the accepts).
>   - TSaslServerTransport->getTransport() called TSaslTransport->open()
>   - TSaslServerTransport->open() tried to negotiate SASL which calls
>     read/write
>     - If read/write blocks indefinitely, the TThreadPoolServer could
>       not accept connections until tcp_keepalive kicked in.
> - Set the underlying TSocket's recvTimeout and sendTimeout before the
>   TSaslServerTransport->open() and reset them to 0 after open()
>   completes.
> - Added sasl_connect_tcp_timeout_ms flag that defaults to 300000
>   milliseconds (5 minutes)
> - Add the ability for TAcceptQueueServer to limit the maximum
>   number of concurrent tasks
> - Added a test case to thrift-server-test to test
>   max_concurrent_connections enforcement
> - Changed the remaining Thrift servers to use TAcceptQueueServer.
>   (hs2/beeswax/network-perf-benchmark)
>   - The timeout is still needed in TAcceptQueueServer since
>     SetupConnection follows a similar pattern that TThreadPoolServer
>     does.
> - Removed support for TThreadPool from ThriftServer() since it is
>   no longer used anywhere. ThriftServer() now always uses
>   TAcceptQueueServer.
> - Deprecated enable_accept_queue_server flag and removed supporting
>   code.
>
> Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
> Reviewed-on: http://gerrit.cloudera.org:8080/7061
> Reviewed-by: Sailesh Mukil <sailesh@cloudera.com>
> Tested-by: Impala Public Jenkins
> ---
> M be/src/benchmarks/network-perf-benchmark.cc
> M be/src/common/global-flags.cc
> M be/src/rpc/TAcceptQueueServer.cpp
> M be/src/rpc/TAcceptQueueServer.h
> M be/src/rpc/thrift-server-test.cc
> M be/src/rpc/thrift-server.cc
> M be/src/rpc/thrift-server.h
> M be/src/service/impala-server.cc
> M be/src/transport/TSaslServerTransport.cpp
> M common/thrift/metrics.json
> 10 files changed, 157 insertions(+), 110 deletions(-)
>
> To view, visit change 7061 <http://gerrit.cloudera.org:8080/7061>. To
> unsubscribe, visit settings <http://gerrit.cloudera.org:8080/settings>.
> Gerrit-Project: Impala-ASF
> Gerrit-Branch: master
> Gerrit-MessageType: merged
> Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
> Gerrit-Change-Number: 7061
> Gerrit-PatchSet: 14
> Gerrit-Owner: John Sherman <jfs@arcadiadata.com>
> Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
> Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
> Gerrit-Reviewer: Impala Public Jenkins
> Gerrit-Reviewer: John Sherman <jfs@arcadiadata.com>
> Gerrit-Reviewer: Matthew Jacobs <mjacobs@apache.org>
> Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
> Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
>
> --
> You received this message because you are subscribed to the Google Groups
> "impala-cr" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to impala-cr+unsubscribe@cloudera.com.
> For more options, visit https://groups.google.com/a/cloudera.com/d/optout.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message