impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3887: Use dfs.namenode.replication.min0A
Date Tue, 31 Oct 2017 05:27:03 GMT
Alex Behm has posted comments on this change. ( )

Change subject: IMPALA-3887: Use dfs.namenode.replication.min=3

Patch Set 1:

(1 comment)

Don't have many data points regarding the effects on build+test runtimes.

The master-core tests have pretty high variance.
A quick examination showed times ranging roughly from 4:50 to 5:20.
The same job with this patch ran in 5:12 so at least it seems within the same ballpark.

I'll do an exhaustive test run and report numbers on that.
File fe/src/test/resources/hbase-site.xml.template:
PS1, Line 38: <!-- Our tests expect to have 3 replicas. Force completing all replicas before
            :    writes to avoid test failures due to temporarily underreplicated blocks.
            :   <property>
            :     <name>dfs.namenode.replication.min</name>
            :     <value>3</value>
            :   </property>
> Isn't this redundant? Per my understanding, this only goes into HDFS servic
Good question, let me give it a try.

I originally tried without modifying hbase-site at all and that didn't work, maybe setting
dfs.replication is enough. I agree that setting the min replication here seems weird/unnecessary.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie09efdd9512cc4f0e338919af42bcdcede2cfb93
Gerrit-Change-Number: 8426
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Behm <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Comment-Date: Tue, 31 Oct 2017 05:27:03 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message