impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test
Date Tue, 31 Oct 2017 00:05:00 GMT
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 )

Change subject: IMPALA-6124: Fix alter table ddl updates and test
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8411/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8411/6//COMMIT_MSG@10
PS6, Line 10: makes
> remove
Done


http://gerrit.cloudera.org:8080/#/c/8411/6//COMMIT_MSG@11
PS6, Line 11: .
> ..to be consistent with Hive...?
Done


http://gerrit.cloudera.org:8080/#/c/8411/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/8411/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a2784
PS6, Line 2784: 
> Just for my understanding, this change is only for add/drop partitions righ
Correct. This one is called from code that updates the stats through "applyAlterPartition()",
so I left it in place.



-- 
To view, visit http://gerrit.cloudera.org:8080/8411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3126252e7709304d3e1fa4bb06a0b847180bd6cf
Gerrit-Change-Number: 8411
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Oct 2017 00:05:00 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message