impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6124: Fix alter table ddl updates and test
Date Mon, 30 Oct 2017 23:43:12 GMT
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8411 )

Change subject: IMPALA-6124: Fix alter table ddl updates and test
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8411/4/tests/metadata/test_last_ddl_time_update.py
File tests/metadata/test_last_ddl_time_update.py:

http://gerrit.cloudera.org:8080/#/c/8411/4/tests/metadata/test_last_ddl_time_update.py@25
PS4, Line 25: class TestLastDdlTimeUpdate(ImpalaTestSuite):
> Does this test still make sense? There's no code on our side that modifies 
Sorry, I was thinking ahead. Nvm this comment.



-- 
To view, visit http://gerrit.cloudera.org:8080/8411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3126252e7709304d3e1fa4bb06a0b847180bd6cf
Gerrit-Change-Number: 8411
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Oct 2017 23:43:12 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message