impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test
Date Mon, 30 Oct 2017 17:35:52 GMT
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 )

Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8412/1/be/src/rpc/thrift-server-test.cc
File be/src/rpc/thrift-server-test.cc:

http://gerrit.cloudera.org:8080/#/c/8412/1/be/src/rpc/thrift-server-test.cc@109
PS1, Line 109: string current_executable_path;
> Brief comment why this needs to be here. Alternative: static member in the 
Added a comment.

Adding this to the ThriftParamsTest will not fix this issue since the InitAuth() code maintains
process wide state and does not have a shutdown mechanism.

So, the threads started by it will keep running in the background even when ~ThriftParamsTest()
is called, leading to the possibility of the same use-after-free bug.

This is not ideal, but for the Impala process we need to start the authentication code only
once. For the purpose of testing, we need to add a clean shutdown mechanism, so that we can
start and stop the auth library for each test case. Right now we do it only for one test case.
This is tracked by IMPALA-6085.



-- 
To view, visit http://gerrit.cloudera.org:8080/8412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cd434757de2cd384def5b360a479e51812cccca
Gerrit-Change-Number: 8412
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Oct 2017 17:35:52 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message