impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating
Date Sun, 29 Oct 2017 19:16:49 GMT
Hello Alex Behm, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8410

to look at the new patch set (#2).

Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating
......................................................................

IMPALA-6118: Fix assertion failure in coordinator bloom filter updating

Coordinator::UpdateFilter wrongly assumed std::string::capacity() to be
0 after std::string::clear(), resulting in an DCHECK failure in memory
tracking. This patch tracks size() instead of capacity() to fix the bug.

Change-Id: Ia28f9eb8d0b3e795d798949a1cfcfeaaec7040ed
---
M be/src/runtime/coordinator.cc
1 file changed, 6 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/8410/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia28f9eb8d0b3e795d798949a1cfcfeaaec7040ed
Gerrit-Change-Number: 8410
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message