impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-6118: Fix assertion failure in coordinator bloom filter updating
Date Sat, 28 Oct 2017 04:41:53 GMT
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8410 )

Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8410/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

http://gerrit.cloudera.org:8080/#/c/8410/1/be/src/runtime/coordinator.cc@1180
PS1, Line 1180:   bloom_filter_.directory.clear();
I think the bigger problem here is actually that the memory of the string is not freed (meaning
we have a big chunk of untracked memory!). You could create a new string on the stack and
move() the contents into that string, so the memory is freed.

Then I think the old assumption of 0 capacity is valid again.



-- 
To view, visit http://gerrit.cloudera.org:8080/8410
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia28f9eb8d0b3e795d798949a1cfcfeaaec7040ed
Gerrit-Change-Number: 8410
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Comment-Date: Sat, 28 Oct 2017 04:41:53 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message