impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5243: Speed up code gen for wide Avro tables.
Date Fri, 27 Oct 2017 21:39:33 GMT
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8211
)

Change subject: IMPALA-5243: Speed up code gen for wide Avro tables.
......................................................................


Patch Set 8:

> Patch Set 8:
> 
> > Oof. GVO caught a (correct) clang-tidy issue. Alas, clang-tidy is
>  > not in pre-review-test, so this was my first experience with that.
> 
> You can also use https://jenkins.impala.io/view/Utility/job/gerrit-verify-dryrun-external/
, which does run clang-tidy.

Thanks for the pointer. I'm giving it a shot at https://jenkins.impala.io/job/gerrit-verify-dryrun-external/25/

My local clang-tidy build was clean:

$ bin/run_clang_tidy.sh | tee clang_tidy.txt
$ cat clang_tidy.txt | grep ']'                                                          
                                                                 $


-- 
To view, visit http://gerrit.cloudera.org:8080/8211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f1b390be4adf6e6699a18344234f8ff7ee74476
Gerrit-Change-Number: 8211
Gerrit-PatchSet: 8
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Fri, 27 Oct 2017 21:39:33 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message