impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2758: Remove BufferedTupleStream::GetRows
Date Thu, 26 Oct 2017 22:22:34 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8226 )

Change subject: IMPALA-2758: Remove BufferedTupleStream::GetRows
......................................................................


Patch Set 4: Code-Review+2

(4 comments)

Looks good, just did a final pass and caught a couple more things. If you fix those and rebase
then I can start the merge.

http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.h
File be/src/exec/partitioned-hash-join-node.h:

http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.h@482
PS4, Line 482:   bool output_null_aware_probe_rows_running_;
Longer-term we should think about ways to reduce the sheer number of stateful member variables
in this class and make the state machine in GetNext() easier to understand.


http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.cc
File be/src/exec/partitioned-hash-join-node.cc:

http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.cc@949
PS4, Line 949:     RowBatch null_build_batch(child(1)->row_desc(), state->batch_size(),
This can fit on one line.


http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.cc@962
PS4, Line 962:       null_build_batch.Reset();
We should add a RETURN_IF_CANCELLED() check here, similar to the one below (I think this was
an oversight in an earlier patch).


http://gerrit.cloudera.org:8080/#/c/8226/4/be/src/exec/partitioned-hash-join-node.cc@1074
PS4, Line 1074:       RowBatch build_batch(child(1)->row_desc(), state->batch_size(),
This can fit on one line.



-- 
To view, visit http://gerrit.cloudera.org:8080/8226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3831c38994da2b69775a9809ff01de5d23584414
Gerrit-Change-Number: 8226
Gerrit-PatchSet: 4
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Oct 2017 22:22:34 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message