impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranay Singh (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5142 EventSequence displays negative elapsed time.
Date Wed, 25 Oct 2017 18:33:36 GMT
Pranay Singh has posted comments on this change. ( )

Change subject: IMPALA-5142 EventSequence displays negative elapsed time.

Patch Set 2:

File be/src/util/
PS2, Line 658:       event_sequence.second->GetEvents(&events);
             :       if (last == 0 && events.size() > 0) last = events.back().second;
> that looks like it could be inconsistent with the sorted order
Introduced a fix to check and fix the event order in event list in GetEvents()
PS2, Line 672: 
> has a test case that expects GetEvents() to be in o
The events are printed in the list order and as they are printed the value of current is decremented
from previous to get the elapsed time. So we are getting a list of events that are not in

I've moved the sorting code in GetEvents() as per your suggestion which seems to be more plausible.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c944396d96473b17b453da3e913ffc56680a896
Gerrit-Change-Number: 8215
Gerrit-PatchSet: 2
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Pranay Singh
Gerrit-Comment-Date: Wed, 25 Oct 2017 18:33:36 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message