impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1291: Parquet read fails if io buffer size is less than the footer size
Date Wed, 25 Oct 2017 18:07:48 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8366 )

Change subject: IMPALA-1291: Parquet read fails if io buffer size is less than the footer
size
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

One final request then I can start the merge.

http://gerrit.cloudera.org:8080/#/c/8366/2/be/src/common/init.cc
File be/src/common/init.cc:

http://gerrit.cloudera.org:8080/#/c/8366/2/be/src/common/init.cc@199
PS2, Line 199: strings::
The strings:: prefix isn't needed - this is one of the things common/names.h imports automatically.



-- 
To view, visit http://gerrit.cloudera.org:8080/8366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7364147e7daf5380f11368871f8479646b448da
Gerrit-Change-Number: 8366
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <boroknagyz@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Oct 2017 18:07:48 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message