impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Csaba Ringhofer (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options
Date Tue, 24 Oct 2017 14:48:44 GMT
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, 

I'd like you to reexamine a change. Please visit

to look at the new patch set (#12).

Change subject: IMPALA-5736: Add impala-shell argument to set default query options

IMPALA-5736: Add impala-shell argument to set default query options

Query options can be set from command line and impala rc as
key=value pairs, where key is case insensitive.

command line: -Q MT_DOP=1 --query_option=MAX_ERRORS=200


The options set in command line will update the ones
in impalarc one by one, so the result of the example
above will be:

Additional changes:
- 0 and 1 are accepted as bools in section [impala] to
  make it more consistent with [impala.query options]
- options that are expected to be bool but are not
  0/1/true/false lead to error instead of warning

Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986
M shell/
M shell/
A tests/shell/impalarc_with_error
A tests/shell/impalarc_with_query_options
A tests/shell/impalarc_with_warnings
M tests/shell/
M tests/shell/
7 files changed, 134 insertions(+), 40 deletions(-)

  git pull ssh:// refs/changes/38/8038/12
To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986
Gerrit-Change-Number: 8038
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer <>
Gerrit-Reviewer: Csaba Ringhofer <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: anujphadke <>

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message