impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5018: Error on decimal modulo or divide by zero
Date Tue, 24 Oct 2017 00:12:18 GMT
Taras Bobrovytsky has posted comments on this change. (

Change subject: IMPALA-5018: Error on decimal modulo or divide by zero

Patch Set 3:

File be/src/exprs/
PS3, Line 729: divide
> My thought here when I suggested it was that the module was just an output 
In one of the previous comments, Vuk mentioned that Postgres returns an identical error message
for both mod and division: "ERROR: division by zero"

Personally, I don't think it's too confusing if it leave it is as. Or maybe it can be modified
to "Cannot modulo decimal or divide decimal by zero" What do you think?
File be/src/exprs/
PS3, Line 2264:      { true, false, 0, 38, 19 }}},
> it would be good to test also 
Added tests to pytest.
PS3, Line 2506: 0/0
> I think we should even change the math function fmod to return a consistent
Created IMPALA-6103.
File testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test:
PS3, Line 46: cast
> is that cast necessary? Let's also verify you get the error without the cas

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7a7131e657fcdd293ade78d62f851dac0f1e3eb
Gerrit-Change-Number: 8344
Gerrit-PatchSet: 3
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Reviewer: Vuk Ercegovac <>
Gerrit-Reviewer: Zach Amsden <>
Gerrit-Reviewer: anujphadke <>
Gerrit-Comment-Date: Tue, 24 Oct 2017 00:12:18 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message