impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding
Date Mon, 23 Oct 2017 21:12:27 GMT
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 )

Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding
......................................................................


Patch Set 11:

(4 comments)

One more questions, looks good to me otherwise.

http://gerrit.cloudera.org:8080/#/c/8267/8/be/src/util/bit-packing.inline.h
File be/src/util/bit-packing.inline.h:

http://gerrit.cloudera.org:8080/#/c/8267/8/be/src/util/bit-packing.inline.h@56
PS8, Line 56:   switch (bit_width) {
> I restructured it a bit more to separate out the macro definition from the 
Much better, thx.


http://gerrit.cloudera.org:8080/#/c/8267/8/be/src/util/dict-test.cc
File be/src/util/dict-test.cc:

http://gerrit.cloudera.org:8080/#/c/8267/8/be/src/util/dict-test.cc@193
PS8, Line 193: // Make sure that SetData() resets the dictionary decoder, including the embedded
RLE
> I originally added it because I had a bug here that was somewhat tricky to 
Thank you for clarifying this.


http://gerrit.cloudera.org:8080/#/c/8267/11/be/src/util/dict-test.cc
File be/src/util/dict-test.cc:

http://gerrit.cloudera.org:8080/#/c/8267/11/be/src/util/dict-test.cc@234
PS11, Line 234:   // Generate a dictionary with 9 values (requires 3 bits to encode).
I don't understand how 3 bits can encode 9 different values. Should these be 8 values instead?


http://gerrit.cloudera.org:8080/#/c/8267/8/be/src/util/rle-test.cc
File be/src/util/rle-test.cc:

http://gerrit.cloudera.org:8080/#/c/8267/8/be/src/util/rle-test.cc@120
PS8, Line 120: num_vals,
> I don't feel strongly either way and I'm probably not that consistent. I've
Sounds good.



-- 
To view, visit http://gerrit.cloudera.org:8080/8267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35de0cf80c86f501c4a39270afc8fb8111552ac6
Gerrit-Change-Number: 8267
Gerrit-PatchSet: 11
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Oct 2017 21:12:27 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message