impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-6070: Parallel compute table
Date Mon, 23 Oct 2017 19:14:29 GMT
David Knupp has posted comments on this change. ( )

Change subject: IMPALA-6070: Parallel

Patch Set 4:

File tests/util/
PS2, Line 48: ror=False, par
> It's a closure. Doing it inline in the main block lets the closure access o
Thanks for the clarification.
PS2, Line 71: end(pool.apply_async(compute_stats_table
> Let's say all_tables = ["a", "b", "c"] and selected_tables = ["b", "c", "d"
Thanks for the clarification. I actually missed that you do the same thing for dbs on L67.
I wasn't considering the fact that selected_tables might contain a table that's not in all_tables,
or that selected_dbs might contain a db that's not in all_dbs. So one last probably naive
question. Does screening out values that don't exist in all_* represent a possible silent
failure -- say, if someone invokes the script with --db_names followed by a misspelled value?

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb080f2552b9dbe304ecadd6e52429214094237d
Gerrit-Change-Number: 8354
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Comment-Date: Mon, 23 Oct 2017 19:14:29 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message