impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.
Date Mon, 23 Oct 2017 19:10:37 GMT
Michael Brown has posted comments on this change. ( )

Change subject: IMPALA-4704: Turns on client connections when local catalog initialized.

Patch Set 11:

File bin/
PS11, Line 258: return not impala_cluster.catalogd and not options.disable_catalog
Why not:

  return impala_cluster.catalogd or options.disable_catalog
PS11, Line 317: ;
remove stray semicolon
PS11, Line 323: client_beeswax.close()
What about closing the HS2 client?
PS11, Line 327: Client ports within %s seconds.' % timeout_in_seconds
Can we make this error message clearer?  "Client ports not ready within N seconds", for instance.
PS11, Line 407:     # Check for the cluster to be ready only when the catalog was started.
              :     if not options.disable_catalog:
              :       wait_for_cluster()
Is this too lax? Can we not call wait_for_impala_process_count()?
File tests/custom_cluster/
PS11, Line 26: cls
Nit: This is a bound object method, so the first argument here is going to be the object,
not the class. Use the name "self" here.
PS11, Line 28: cls
PS11, Line 30: cls
self here and below as well
PS11, Line 45: with pytest.raises(Exception) as e

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52b881cba18a7e4533e21a78751c2e35c3d4c8a6
Gerrit-Change-Number: 8202
Gerrit-PatchSet: 11
Gerrit-Owner: Vuk Ercegovac <>
Gerrit-Reviewer: Balazs Jeszenszky <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: Vuk Ercegovac <>
Gerrit-Comment-Date: Mon, 23 Oct 2017 19:10:37 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message