impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.
Date Fri, 20 Oct 2017 21:59:26 GMT
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 )

Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8305/5/be/src/runtime/timestamp-value.h
File be/src/runtime/timestamp-value.h:

http://gerrit.cloudera.org:8080/#/c/8305/5/be/src/runtime/timestamp-value.h@107
PS5, Line 107:   static TimestampValue FromUnixTimeMicros(int64_t unix_time_micros);
nit: blank line between function declaration.


http://gerrit.cloudera.org:8080/#/c/8305/5/be/src/runtime/timestamp-value.inline.h
File be/src/runtime/timestamp-value.inline.h:

http://gerrit.cloudera.org:8080/#/c/8305/5/be/src/runtime/timestamp-value.inline.h@45
PS5, Line 45: }
nit: blank line between functions.


http://gerrit.cloudera.org:8080/#/c/8305/5/be/src/util/common-metrics.cc
File be/src/util/common-metrics.cc:

http://gerrit.cloudera.org:8080/#/c/8305/5/be/src/util/common-metrics.cc@36
PS5, Line 36: ToStringFromUnixMicros(UnixMicros())
This seems to be useful in general and used in multiple places in this patch. Is it worth
factoring this into an inline function with a shorter and meaningful name ?



-- 
To view, visit http://gerrit.cloudera.org:8080/8305
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I642a1d713597826bb7c15cd2ecb6638cb813a02c
Gerrit-Change-Number: 8305
Gerrit-PatchSet: 5
Gerrit-Owner: Zoram Thanga <zoram@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zoram@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Oct 2017 21:59:26 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message