impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5018: Error on decimal divide by and modulo zero
Date Fri, 20 Oct 2017 19:56:32 GMT
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8344
)

Change subject: IMPALA-5018: Error on decimal divide by and modulo zero
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8344/1/be/src/exprs/decimal-operators-ir.cc
File be/src/exprs/decimal-operators-ir.cc:

http://gerrit.cloudera.org:8080/#/c/8344/1/be/src/exprs/decimal-operators-ir.cc@737
PS1, Line 737: Decimal division by or modulo zero
> For either / or %, postgres reports:
Done


http://gerrit.cloudera.org:8080/#/c/8344/1/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

http://gerrit.cloudera.org:8080/#/c/8344/1/be/src/exprs/expr-test.cc@1567
PS1, Line 1567:   { "cast(1.23 as decimal(8,2)) + cast(1 as decimal(20,3))", {{ false, false,
2230, 21, 3 }}},
> Long lines.
Done


http://gerrit.cloudera.org:8080/#/c/8344/1/be/src/exprs/expr-test.cc@1567
PS1, Line 1567:   { "cast(1.23 as decimal(8,2)) + cast(1 as decimal(20,3))", {{ false, false,
2230, 21, 3 }}},
> Long lines.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7a7131e657fcdd293ade78d62f851dac0f1e3eb
Gerrit-Change-Number: 8344
Gerrit-PatchSet: 1
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercegovac@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Oct 2017 19:56:32 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message