impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bikramjeet Vig (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder
Date Thu, 19 Oct 2017 21:41:48 GMT
Bikramjeet Vig has posted comments on this change. ( )

Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

Patch Set 10:

File be/src/exec/hdfs-parquet-scanner.h:
PS10, Line 352: return mem_tracker_;
if this is the same mem tracker in scan_node_ perhaps we can just do 
over here and avoid adding a new member variable?
Same in the hdfs-table-writer.
File be/src/exec/
PS10, Line 337: if (mem_tracker_ != nullptr) {
              :     mem_tracker_ = nullptr;
              :   }
nit: one line

if (mem_tracker_ != nullptr) mem_tracker_ = nullptr;
File be/src/exec/parquet-column-readers.h:
PS10, Line 356: if (dict_decoder_base_ != nullptr) dict_decoder_base_->Close();
instead of dict_decoder_base_ we can just use the virtual function GetDictionaryDecoder()
to get the dict if it exists
File be/src/util/dict-encoding.h:
PS10, Line 206: 
nit: extra line
PS10, Line 324: 
nit: extra line

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02a3b54f6c107d19b62ad9e1c49df94175964299
Gerrit-Change-Number: 8034
Gerrit-PatchSet: 10
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Bikramjeet Vig <>
Gerrit-Reviewer: Joe McDonnell <>
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Thu, 19 Oct 2017 21:41:48 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message