impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.
Date Thu, 19 Oct 2017 03:40:11 GMT
Alex Behm has posted comments on this change. ( )

Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

Patch Set 7:

File fe/src/main/java/org/apache/impala/service/
PS7, Line 1958:           Lists.partition(allHmsPartitionsToAdd, MAX_PARTITION_UPDATES_PER_RPC))
While you are here, can you also change bulkAlterPartitions() to use Lists.partition()?
File tests/metadata/
PS7, Line 514:   def test_alter_table_create_many_partitions(self, vector, unique_database):
This test doesn't belong in the TestLibCache class.

Don't we have existing tests that test the multi-partition add alter? Seems like this test
belongs there.
PS7, Line 519:     self.client.execute('use {0}'.format(unique_database))
"use" can generally cause problems in tests because we sometimes run a test against different
impalads for example to exercise sync_ddl. While I think it is ok in this specific instance,
it's generally better practice not so issue "use" statements unless absolutely necessary.
PS7, Line 527:     # 473     -1      0       0B      NOT CACHED      NOT CACHED      TEXT
   false   hdfs://localhost:20500/test-warehouse/test_alter_table_create_many_partitions_5b4888f5.db/t/p=473
This comment can become stale quickly. I suggest not adding it an output row verbatim but
mentioning that show partitions contains the partition HDFS paths which we expect to contain
p=val sub-directories that you are going to search for with the regex.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f8221ff08c0f126f951f7d37ff5e57985f855f
Gerrit-Change-Number: 8238
Gerrit-PatchSet: 7
Gerrit-Owner: Philip Zeyliger <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Comment-Date: Thu, 19 Oct 2017 03:40:11 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message